[igt-dev] [V5 i-g-t 44/81] tests/kms_display_modes: Document each subtest for testplan

[Sharma, Swati2]

On 09-Aug-23 10:57 AM, B, Jeevan wrote:
>> -----Original Message-----
>> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of
>> Bhanuprakash Modem
>> Sent: Thursday, June 29, 2023 8:19 PM
>> To: igt-dev at lists.freedesktop.org
>> Subject: [igt-dev] [V5 i-g-t 44/81] tests/kms_display_modes: Document each
>> subtest for testplan
>>
>> Add documentation for all kms tests which is used by IGT testplan
>> documentation.
>>
>> V2: - Add missing documentation
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> 
> LGTM.
> Reviewed-by: Jeevan B <jeevan.b at intel.com>
>> ---
>>   tests/kms_display_modes.c | 25 +++++++++++++++++++++++++
>>   1 file changed, 25 insertions(+)
>>
>> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c index
>> 93d91ef5b..b26a3f71a 100644
>> --- a/tests/kms_display_modes.c
>> +++ b/tests/kms_display_modes.c
>> @@ -24,6 +24,11 @@
>>    *  Jeevan B <jeevan.b at intel.com>
>>    */
>>
>> +/**
>> + * TEST: kms display modes
>> + * Category: Display
>> + * Description: Test Display Modes
>> + */
>>   #include "igt.h"
>>
>>   #define HDISPLAY_4K	3840
>> @@ -231,6 +236,16 @@ static void run_extendedmode_basic(data_t *data,
>>   	for_each_connected_output_local((display), (output)) \
>>   		for_each_if (igt_pipe_connector_valid((pipe), (output)))
>>
>> +/**
>> + * SUBTEST: extended-mode-basic
>> + * Description: Test for validating display extended mode with a pair of
>> connected
>> + *              displays
>> + * Driver requirement: any
>> + * Functionality: kms_core
>> + * Mega feature: General Display Features
>> + * Run type: FULL
>> + * Test category: functionality test
>> + */
>>   static void run_extendedmode_test(data_t *data) {
>>   	enum pipe pipe1, pipe2;
>>   	igt_output_t *output1, *output2;
>> @@ -276,6 +291,16 @@ static void run_extendedmode_test(data_t *data) {
>>   	}
>>   }
>>
>> +/**
>> + * SUBTEST: mst-extended-mode-negative
>> + * Description: Negative test for validating display extended mode with a
>> pair
>> + *		of connected 2k-4k or 4k-4k displays.
>> + * Driver requirement: any
>> + * Functionality: kms_core

Should we add functionality as mst here?

>> + * Mega feature: General Display Features
>> + * Run type: FULL
>> + * Test category: functionality test
>> + */
>>   static void run_extendedmode_negative(data_t *data, int pipe1, int pipe2)
>> {
>>   	struct igt_fb fbs[2];
>> --
>> 2.40.0
>