[igt-dev] [v2] tests/intel-ci: chamelium specific fast-feedback

[Kamil Konieczny]

Hi Swati,

On 2023-08-16 at 11:17:31 +0530, Swati Sharma wrote:
> In BAT, chamelium setups are not frequently deployed. So, to

Try to avoid starting sentence from "So, ", you can drop it
and write: "To enhance ..."
 
> enhance overall execution efficiency, its recommended to
--------------------------------------- ^^^
"It's" or "It is"

> remove chamelium tests from fast-feedback/xe-fast-feedback and
> create a dedicated fast-feedback-chamelium-only/xe-fast-feedback-chamelium-only
> testlists for executing chamelium tests.
> 
> v2: -update xe fast-feedback testlist (Kunal)
> 
> Signed-off-by: Swati Sharma <swati2.sharma at intel.com>
> Reviewed-by: Kunal Joshi <kunal1.joshi at intel.com>
> ---
>  .../fast-feedback-chamelium-only.testlist         | 15 +++++++++++++++
>  tests/intel-ci/fast-feedback.testlist             |  9 ---------
>  .../xe-fast-feedback-chamelium-only.testlist      | 15 +++++++++++++++
>  tests/intel-ci/xe-fast-feedback.testlist          |  9 ---------
>  4 files changed, 30 insertions(+), 18 deletions(-)
>  create mode 100644 tests/intel-ci/fast-feedback-chamelium-only.testlist
>  create mode 100644 tests/intel-ci/xe-fast-feedback-chamelium-only.testlist
> 
> diff --git a/tests/intel-ci/fast-feedback-chamelium-only.testlist b/tests/intel-ci/fast-feedback-chamelium-only.testlist
> new file mode 100644
> index 000000000..365bcf448
> --- /dev/null
> +++ b/tests/intel-ci/fast-feedback-chamelium-only.testlist
> @@ -0,0 +1,15 @@
> +# Should be the first test
> +igt at i915_module_load@load
> +
> +# Keep alphabetically sorted by default
> +igt at kms_chamelium_hpd@dp-hpd-fast
-------------------- ^
> +igt at kms_chamelium_edid@dp-edid-read
> +igt at kms_chamelium_frames@dp-crc-fast
> +igt at kms_chamelium_hpd@hdmi-hpd-fast
> +igt at kms_chamelium_edid@hdmi-edid-read
> +igt at kms_chamelium_frames@hdmi-crc-fast
> +igt at kms_chamelium_hpd@vga-hpd-fast
> +igt at kms_chamelium_edid@vga-edid-read

It still need to be sorted.

> +
> +# System wide suspend tests in the end
> +igt at kms_chamelium_hpd@common-hpd-after-suspend
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 31639c892..c09c6c417 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -92,14 +92,6 @@ igt at kms_addfb_basic@unused-modifier
>  igt at kms_addfb_basic@unused-offsets
>  igt at kms_addfb_basic@unused-pitches
>  igt at kms_busy@basic
> -igt at kms_chamelium_hpd@dp-hpd-fast
> -igt at kms_chamelium_edid@dp-edid-read
> -igt at kms_chamelium_frames@dp-crc-fast
> -igt at kms_chamelium_hpd@hdmi-hpd-fast
> -igt at kms_chamelium_edid@hdmi-edid-read
> -igt at kms_chamelium_frames@hdmi-crc-fast
> -igt at kms_chamelium_hpd@vga-hpd-fast
> -igt at kms_chamelium_edid@vga-edid-read
>  igt at kms_prop_blob@basic
>  igt at kms_cursor_legacy@basic-busy-flip-before-cursor-atomic
>  igt at kms_cursor_legacy@basic-busy-flip-before-cursor-legacy
> @@ -179,5 +171,4 @@ igt at i915_suspend@basic-s2idle-without-i915
>  igt at i915_suspend@basic-s3-without-i915
>  igt at gem_exec_suspend@basic-s0
>  igt at gem_exec_suspend@basic-s3
> -igt at kms_chamelium_hpd@common-hpd-after-suspend
>  igt at kms_pipe_crc_basic@suspend-read-crc
> diff --git a/tests/intel-ci/xe-fast-feedback-chamelium-only.testlist b/tests/intel-ci/xe-fast-feedback-chamelium-only.testlist
> new file mode 100644
> index 000000000..727668f0e
> --- /dev/null
> +++ b/tests/intel-ci/xe-fast-feedback-chamelium-only.testlist
> @@ -0,0 +1,15 @@
> +# Should be the first test
> +igt at xe_module_load@load
> +
> +# Keep alphabetically sorted by default
> +igt at kms_chamelium_hpd@dp-hpd-fast
> +igt at kms_chamelium_edid@dp-edid-read
> +igt at kms_chamelium_frames@dp-crc-fast
> +igt at kms_chamelium_hpd@hdmi-hpd-fast
> +igt at kms_chamelium_edid@hdmi-edid-read
> +igt at kms_chamelium_frames@hdmi-crc-fast
> +igt at kms_chamelium_hpd@vga-hpd-fast
> +igt at kms_chamelium_edid@vga-edid-read

Same here, sort it. With this corrected
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

Regards,
Kamil

> +
> +# System wide suspend tests in the end
> +igt at kms_chamelium_hpd@common-hpd-after-suspend
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index 5dcca4aec..311f90c79 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -207,15 +207,6 @@ igt at kms_addfb_basic@unused-handle
>  igt at kms_addfb_basic@unused-modifier
>  igt at kms_addfb_basic@unused-offsets
>  igt at kms_addfb_basic@unused-pitches
> -igt at kms_chamelium_edid@dp-edid-read
> -igt at kms_chamelium_edid@hdmi-edid-read
> -igt at kms_chamelium_edid@vga-edid-read
> -igt at kms_chamelium_frames@dp-crc-fast
> -igt at kms_chamelium_frames@hdmi-crc-fast
> -igt at kms_chamelium_hpd@common-hpd-after-suspend
> -igt at kms_chamelium_hpd@dp-hpd-fast
> -igt at kms_chamelium_hpd@hdmi-hpd-fast
> -igt at kms_chamelium_hpd@vga-hpd-fast
>  igt at kms_cursor_legacy@basic-flip-after-cursor-atomic
>  igt at kms_cursor_legacy@basic-flip-after-cursor-legacy
>  igt at kms_cursor_legacy@basic-flip-after-cursor-varying-size
> -- 
> 2.25.1
>