[igt-dev] [i-g-t V6 76/81] tests/kms_universal_plane: Document each subtest for testplan

[B, Jeevan]

> -----Original Message-----
> From: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>
> Sent: Wednesday, August 16, 2023 3:20 PM
> To: B, Jeevan <jeevan.b at intel.com>; igt-dev at lists.freedesktop.org
> Subject: Re: [i-g-t V6 76/81] tests/kms_universal_plane: Document each
> subtest for testplan
> 
> Hi Jeevan,
> 
> On Wed-16-08-2023 11:44 am, B, Jeevan wrote:
> >> -----Original Message-----
> >> From: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>
> >> Sent: Saturday, August 12, 2023 12:17 AM
> >> To: igt-dev at lists.freedesktop.org
> >> Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>; B,
> Jeevan
> >> <jeevan.b at intel.com>
> >> Subject: [i-g-t V6 76/81] tests/kms_universal_plane: Document each
> >> subtest for testplan
> >>
> >> Add documentation for all kms tests which is used by IGT testplan
> >> documentation.
> >>
> >> V2: - Fix test description
> >>
> >> Cc: Jeevan B <jeevan.b at intel.com>
> >> Signed-off-by: Bhanuprakash Modem
> <bhanuprakash.modem at intel.com>
Got it thanks. 
LGTM. 
Reviewed-by: Jeevan B <jeevan.b at intel.com>
> >
> > Not all subtest details are added as mentioned in previous version.
> 
> Sorry, I didn't get you. What else is missing here?
> 
> This patch is covering all the subsets in kms_universal_plane. You can verify
> the same by comparing 1 & 2 from igt root directory.
> 
> [1]: ./scripts/igt_doc.py --config=tests/kms_test_config.json
> --files=tests/kms_universal_plane.c --show-subtests
> [2]: ./build/tests/kms_universal_plane --show-testlist
> 
> - Bhanu
> 
> >
> >> ---
> >>   tests/kms_universal_plane.c | 68
> >> +++++++++++++++++++++++++++++++++++++
> >>   1 file changed, 68 insertions(+)
> >>
> >> diff --git a/tests/kms_universal_plane.c
> >> b/tests/kms_universal_plane.c index 957d600f1..a23a0d8cd 100644
> >> --- a/tests/kms_universal_plane.c
> >> +++ b/tests/kms_universal_plane.c
> >> @@ -28,6 +28,74 @@
> >>   #include <string.h>
> >>   #include <fcntl.h>
> >>
> >> +/**
> >> + * TEST: kms universal plane
> >> + * Category: Display
> >> + * Description: Check pageflip & modeset on universal plane
> >> + *
> >> + * SUBTEST: cursor-fb-leak-pipe-%s
> >> + * Description: Check for cursor leaks after performing cursor
> >> +operations on %arg[1]
> >> + * Driver requirement: any
> >> + * Functionality: cursor, plane
> >> + * Mega feature: General Display Features
> >> + * Run type: FULL
> >> + * Test category: functionality test
> >> + *
> >> + * SUBTEST: disable-primary-vs-flip-pipe-%s
> >> + * Description: Check pageflips while primary plane is disabled
> >> +before IOCTL
> >> or
> >> + *              between IOCTL and pageflip execution on %arg[1]
> >> + * Driver requirement: any
> >> + * Functionality: plane
> >> + * Mega feature: General Display Features
> >> + * Run type: FULL
> >> + * Test category: functionality test
> >> + *
> >> + * SUBTEST: universal-plane-pageflip-windowed-pipe-%s
> >> + * Description: Check if pageflip succeeds in windowed setting on
> >> +%arg[1]
> >> + * Driver requirement: any
> >> + * Functionality: plane
> >> + * Mega feature: General Display Features
> >> + * Run type: FULL
> >> + * Test category: functionality test
> >> + *
> >> + * arg[1]:
> >> + *
> >> + * @A:    pipe A
> >> + * @B:    pipe B
> >> + * @C:    pipe C
> >> + * @D:    pipe D
> >> + * @E:    pipe E
> >> + * @F:    pipe F
> >> + * @G:    pipe G
> >> + * @H:    pipe H
> >> + */
> >> +
> >> +/**
> >> + * SUBTEST: universal-plane-pipe-%s-%s
> >> + * Description: Check %arg[2] on %arg[1]
> >> + * Driver requirement: any
> >> + * Functionality: plane
> >> + * Mega feature: General Display Features
> >> + * Run type: FULL
> >> + * Test category: functionality test
> >> + *
> >> + * arg[1]:
> >> + *
> >> + * @A:    pipe A
> >> + * @B:    pipe B
> >> + * @C:    pipe C
> >> + * @D:    pipe D
> >> + * @E:    pipe E
> >> + * @F:    pipe F
> >> + * @G:    pipe G
> >> + * @H:    pipe H
> >> + *
> >> + * arg[2]:
> >> + *
> >> + * @functional: the switching between different primary plane fbs
> >> +with
> >> CRTC off
> >> + * @sanity:     for scale-up or scale-down using universal plane API
> without
> >> + *              covering CRTC
> >> + */
> >>
> >>   typedef struct {
> >>   	int drm_fd;
> >> --
> >> 2.40.0
> >