[igt-dev] [PATCH i-g-t] lib/i915: Add a helper lib to read mmio registers via ioctl

[Kamil Konieczny]

Hi Dixit,

On 2023-08-17 at 06:23:12 -0700, Dixit, Ashutosh wrote:
> On Wed, 16 Aug 2023 07:27:39 -0700, Kamil Konieczny wrote:
> >
> 
> Hi Alan/Kamil,
> 
> > Hi Alan,
> >
> > On 2023-08-15 at 10:36:59 -0700, Alan Previn wrote:
> > > Add a helper lib function to call DRM_IOCTL_I915_REG_READ to
> > > read whitelisted registers.
> > >
> > > Signed-off-by: Alan Previn <alan.previn.teres.alexis at intel.com>
> > > ---
> > >  lib/i915/i915_reg_read_ioctl.c | 34 ++++++++++++++++++++++++++++++++++
> > ---------------- ^^^^^^^^^^^^^^
> >
> > imho better name would be i915_mmio_reg
> >
> > >  lib/i915/i915_reg_read_ioctl.h |  9 +++++++++
> 
> Can't this just go in lib/ioctl_wrappers.*? Do we need a new file for this?
> 
> Thanks.
> --
> Ashutosh

I agree that if possible we should reuse other intel lib.

Regards,
Kamil