[igt-dev] [PATCH i-g-t] tests/core_hotunplug: Improve test documentation

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Aug 18 07:16:21 UTC 2023


Hi Janga Rahul,

On 2023-08-18 at 10:41:52 +0530, janga.rahul.kumar at intel.com wrote:
> From: Janga Rahul Kumar <janga.rahul.kumar at intel.com>
> 
> Add missing category, sub-category and functionality fields.
> 
> Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar at intel.com>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  tests/core_hotunplug.c | 32 ++++++++++++++++++++++++--------
>  1 file changed, 24 insertions(+), 8 deletions(-)
> 
> diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
> index 4d6a721f0..30d9a6a57 100644
> --- a/tests/core_hotunplug.c
> +++ b/tests/core_hotunplug.c
> @@ -45,44 +45,60 @@
>   * Feature: SMI, core
>   *
>   * SUBTEST: hotrebind
> + * Category: Software building block
> + * Sub-category: driver
> + * Functionality: device hotplug
>   * Description:
>   *   Check if the driver can be cleanly rebound to a device with a still open hot unbound driver
>   *   instance
> - * Functionality: device hotplug
>   * Run type: FULL
> - * Test category: SysMan
>   *
>   * SUBTEST: hotrebind-lateclose
> - * Description: Check if a hot unbound driver instance still open after hot rebind can be cleanly released
> + * Category: Software building block
> + * Sub-category: driver
>   * Functionality: device hotplug
> + * Description: Check if a hot unbound driver instance still open after hot rebind can be cleanly released
>   * Run type: FULL
> - * Test category: SysMan
>   *
>   * SUBTEST: hotreplug
> + * Category: Software building block
> + * Sub-category: driver
> + * Functionality: device hotplug
>   * Description: Check if a hot unplugged and still open device can be cleanly restored
>   * Run type: FULL
>   *
>   * SUBTEST: hotreplug-lateclose
> + * Category: Software building block
> + * Sub-category: driver
> + * Functionality: device hotplug
>   * Description: Check if an instance of a still open while hot replugged device can be cleanly released
>   * Run type: FULL
>   *
>   * SUBTEST: hotunbind-rebind
> - * Description: Check if the driver can be cleanly unbound from an open device, then released and rebound
> + * Category: Software building block
> + * Sub-category: driver
>   * Functionality: device hotplug
> + * Description: Check if the driver can be cleanly unbound from an open device, then released and rebound
>   * Run type: FULL
> - * Test category: SysMan
>   *
>   * SUBTEST: hotunplug-rescan
> + * Category: Software building block
> + * Sub-category: driver
> + * Functionality: device hotplug
>   * Description: Check if an open device can be cleanly unplugged, then released and restored
>   * Run type: FULL
>   *
>   * SUBTEST: unbind-rebind
> - * Description: Check if the driver can be cleanly unbound from a device believed to be closed, then rebound
> + * Category: Software building block
> + * Sub-category: driver
>   * Functionality: device hotplug
> + * Description: Check if the driver can be cleanly unbound from a device believed to be closed, then rebound
>   * Run type: BAT
> - * Test category: SysMan
>   *
>   * SUBTEST: unplug-rescan
> + * Category: Software building block
> + * Sub-category: driver
> + * Functionality: device hotplug
>   * Description: Check if a device believed to be closed can be cleanly unplugged, then restored
>   * Run type: FULL
>   */
> -- 
> 2.25.1
> 


More information about the igt-dev mailing list