[igt-dev] [PATCH i-g-t] tests/xe/xe_exec_store: Fix number of placements in store_all

[Zbigniew Kempczyński]

On Fri, Aug 11, 2023 at 10:19:50PM +0530, sai.gowtham.ch at intel.com wrote:
> From: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
> 
> Fix number of placements in store_all using which we can create
> multiple engine instances.
> 
> Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
> ---
>  tests/xe/xe_exec_store.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/xe/xe_exec_store.c b/tests/xe/xe_exec_store.c
> index bab5ea5bc..498aa0f7f 100644
> --- a/tests/xe/xe_exec_store.c
> +++ b/tests/xe/xe_exec_store.c
> @@ -149,7 +149,8 @@ static void store_all(int fd, int gt, int class)
>  		eci[num_placements++] = *hwe;
>  	}
>  
> -	igt_require(num_placements);
> +	if (num_placements < 2)
> +		return;

I think this isn't correct solution for this test. On adlp I've seen
there're two gt's - graphics and media, each which different set of
engines. So you may encounter situation there's no engine according
to iterator loop in 'basic-all' subtest.

I think this loop requires rework to be multi-gt ready.

--
Zbigniew

>  
>  	for (i = 0; i < num_placements; i++) {
>  		struct drm_xe_exec_queue_create create = {
> -- 
> 2.39.1
>