[igt-dev] [PATCH i-g-t] tests/i915: Take into account fbc_status "stolen memory not initialised"

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Mon Aug 21 10:06:17 UTC 2023


Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

On 18.8.2023 11.08, Jouni Högander wrote:
> Earlier non initialized memory caused fbc_status debugfs interface not
> being created at all. This was considered as "Unsupported chipset" by
> certain igt testcases. Now fbc_status is informing "stolen memory not
> initialised". Consider this again as "Unsupported chipset"
> 
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9131
> Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
> ---
>   tests/i915/kms_fbcon_fbt.c            | 3 ++-
>   tests/i915/kms_frontbuffer_tracking.c | 3 ++-
>   2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/kms_fbcon_fbt.c b/tests/i915/kms_fbcon_fbt.c
> index e65cbda93..2cb0ffdb4 100644
> --- a/tests/i915/kms_fbcon_fbt.c
> +++ b/tests/i915/kms_fbcon_fbt.c
> @@ -103,7 +103,8 @@ static bool fbc_supported_on_chipset(int device, int debugfs_fd)
>   	if (ret < 0)
>   		return false;
>   
> -	return !strstr(buf, "FBC unsupported on this chipset\n");
> +	return !strstr(buf, "FBC unsupported on this chipset\n") &&
> +		!strstr(buf, "stolen memory not initialised\n");
>   }
>   
>   static bool connector_can_fbc(drmModeConnectorPtr connector)
> diff --git a/tests/i915/kms_frontbuffer_tracking.c b/tests/i915/kms_frontbuffer_tracking.c
> index 3e8f15bb0..136426204 100644
> --- a/tests/i915/kms_frontbuffer_tracking.c
> +++ b/tests/i915/kms_frontbuffer_tracking.c
> @@ -1444,7 +1444,8 @@ static bool fbc_supported_on_chipset(void)
>   	if (*buf == '\0')
>   		return false;
>   
> -	return !strstr(buf, "FBC unsupported on this chipset\n");
> +	return !strstr(buf, "FBC unsupported on this chipset\n") &&
> +		!strstr(buf, "stolen memory not initialised\n");
>   }
>   
>   static void setup_fbc(void)



More information about the igt-dev mailing list