[igt-dev] [PATCH v4 2/2] tests/amdgpu: Add test for ODM combine

[Kamil Konieczny]

Hi Aurabindo,

On 2023-08-22 at 16:18:08 -0400, Aurabindo Pillai wrote:
> 
> 
> On 2023-08-22 15:45, Kamil Konieczny wrote:
> > Hi Aurabindo,
> > 
> > On 2023-08-21 at 16:18:42 -0400, Aurabindo Pillai wrote:
> > > Thanks for the review Alex.
> > > 
> > > Kamil,
> > > 
> > > There seems to be a false positive failure for this patchset:
> > > https://lists.freedesktop.org/archives/igt-dev/2023-August/060105.html
> > > 
> > > Do you have any further review suggestions or is it okay to merge ?
> > > 
> > 
> > This is not ok, on some images your test will not build,
> > to reproduce:
> > 
> > follow links from failed build to find out what image was used
> > for example here: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/47853345
> > 
> > install podman, enter to igt-tools source dir,
> > then run script:
> > 
> > POD_IGT=registry.freedesktop.org/gfx-ci/igt-ci-tags/build-debian:commit-26f3d20c6ff4274aeb71d4851cdf7a7cefb0a008
> > 
> > mkdir -p /tmp/igt-build
> > cp -R * /tmp/igt-build/
> > sudo podman run -i -t -v /tmp/igt-build/:/opt/builds --privileged ${POD_IGT}
> > 
> > ## end of script
> > 
> > now you will have root prompt '#' inside podman image (debian),
> > enter commands:
> > 
> > # cd /opt/builds
> > # meson build
> > # ninja -C build
> > 
> > imho this is problem on some old(?) systems where the system
> > and/or igt headers are missing.
> > 
> > Please fix this before merging.
> > 
> 
> Hi Kamil,
> 
> Thanks for the detailed steps. The Patchwork CI showed build success, which
> is why I merged the patches. I have a oneliner fix that I'll send to the
> list.

Well I do not see it, even now it shows build failure but there is color
issue with that (for me it is hard to diff between green and that orange).
It shows success (green) for Fi.CI.BAT so maybe you missed GitLab.build
status. Please always look into build warnings, wait a few days for
replay as people sometimes go to vacations/meetings/conferences, ask on
irc #igt/oftc.

I also plan to add some help for container how-to or instead adding some
script into scripts/podman-example.sh. +cc Petri

Regards,
Kamil

> 
> --
> 
> Thanks & Regards,
> Jay