[igt-dev] [PATCH i-g-t] tests/kms_atomic: remove zpos < N-planes assert

Melissa Wen mwen at igalia.com
Tue Aug 29 10:44:58 UTC 2023


On 08/24, Rodrigo Siqueira Jordao wrote:
> 
> 
> On 8/24/23 10:15, Melissa Wen wrote:
> > Generalize plane-immutable-zpos test case by removing not-required
> > assert. zpos < N-planes is a condition not required by DRM
> > documentation. Removing this validation doesn't affect the test purpose
> > on verifying that planes with higher zpos always cover those with lower
> > zpos. Also, this assert doesn't fit driver's configuration where the
> > range of plane zpos is just defined by the plane type but its max value
> > doesn't need to be normalized to the number of planes in a CRTC, for
> > example, a cursor plane with the highest possible zpos value.
> > 
> > Signed-off-by: Melissa Wen <mwen at igalia.com>
> > ---
> >   tests/kms_atomic.c | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
> > index 22ddf5633..6986864f3 100644
> > --- a/tests/kms_atomic.c
> > +++ b/tests/kms_atomic.c
> > @@ -458,7 +458,6 @@ plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
> >   			continue;
> >   		zpos = igt_plane_get_prop(temp, IGT_PLANE_ZPOS);
> > -		igt_assert_lt(zpos, n_planes);
> >   		plane_ptr[zpos] = temp;
> >   	}
> 
> lgtm,
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>

Applied, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20230829/d5dcae26/attachment.sig>


More information about the igt-dev mailing list