[igt-dev] [PATCH i-g-t v3 1/6] lib: Add blt command properties for lunarlake

[Jahagirdar, Akshata]

>-----Original Message-----
>From: Stolarek, Karolina <karolina.stolarek at intel.com> 
>Sent: Wednesday, November 29, 2023 11:41 PM
>To: Jahagirdar, Akshata <akshata.jahagirdar at intel.com>
>Cc: igt-dev at lists.freedesktop.org; Siddiqui, Ayaz A <ayaz.siddiqui at intel.com>; Mmatthew.auld at intel.com; Kempczynski, Zbigniew <zbigniew.kempczynski at intel.com>; >Mishra, Pallavi <pallavi.mishra at intel.com>
>Subject: Re: [PATCH i-g-t v3 1/6] lib: Add blt command properties for lunarlake
>
>
>On 30.11.2023 13:35, Akshata Jahagirdar wrote:
>> Add blt_cmd_info structs to describe properties of XY_BLOCK_COPY and XY_FAST_COPY blitter commands for XE2 platform. Updated the definitions for Lunarlake.
>> 
>> Signed-off-by: Akshata Jahagirdar <akshata.jahagirdar at intel.com>
>> ---
>>   lib/intel_cmds_info.c   | 17 +++++++++++++++++
>>   lib/intel_cmds_info.h   |  1 +
>>   lib/intel_device_info.c |  2 +-
>>   3 files changed, 19 insertions(+), 1 deletion(-)
>> 
>> diff --git a/lib/intel_cmds_info.c b/lib/intel_cmds_info.c index 
>> 2e51ec081..7c8790d8e 100644
>> --- a/lib/intel_cmds_info.c
>> +++ b/lib/intel_cmds_info.c
>> @@ -67,6 +67,15 @@ static const struct blt_cmd_info
>>   						 BLT_CMD_EXTENDED |
>>   						 BLT_CMD_SUPPORTS_COMPRESSION);
>>   
>> +static const struct blt_cmd_info				
>> +		xe2_xy_block_copy = BLT_INFO_EXT(XY_BLOCK_COPY,
>> +						 BIT(T_LINEAR) |
>> +						 BIT(T_XMAJOR) |
>> +						 BIT(T_TILE4)  |
>> +						 BIT(T_TILE64),
>> +						 BLT_CMD_EXTENDED |
>> +						 BLT_CMD_SUPPORTS_COMPRESSION);
>> +
>>   static const struct blt_cmd_info
>>   		mtl_xy_block_copy = BLT_INFO_EXT(XY_BLOCK_COPY,
>>   						 BIT(T_LINEAR) |
>> @@ -169,6 +178,14 @@ const struct intel_cmds_info gen12_pvc_cmds_info = {
>>   	}
>>   };
>>   
>> +
>
>This blank line is unnecessary. Once you fix that and wrap the commit message to 80 chars, feel free to add my:
>
>Reviewed-by: Karolina Stolarek <karolina.stolarek at intel.com>
>
>All the best,
>Karolina
>
Sure, will change it. Thank you.
Best,
Akshata.

>> +const struct intel_cmds_info xe2_cmds_info  = {
>> +	.blt_cmds = {
>> +		[XY_FAST_COPY] = &dg2_xy_fast_copy,
>> +		[XY_BLOCK_COPY] = &xe2_xy_block_copy,
>> +	}
>> +};
>> +
>>   const struct blt_cmd_info *blt_get_cmd_info(const struct intel_cmds_info *cmds_info,
>>   					    enum blt_cmd_type cmd)
>>   {
>> diff --git a/lib/intel_cmds_info.h b/lib/intel_cmds_info.h index 
>> f9e3932d1..0a83b6a44 100644
>> --- a/lib/intel_cmds_info.h
>> +++ b/lib/intel_cmds_info.h
>> @@ -55,6 +55,7 @@ extern const struct intel_cmds_info gen12_cmds_info;
>>   extern const struct intel_cmds_info gen12_dg2_cmds_info;
>>   extern const struct intel_cmds_info gen12_mtl_cmds_info;
>>   extern const struct intel_cmds_info gen12_pvc_cmds_info;
>> +extern const struct intel_cmds_info xe2_cmds_info;
>>   
>>   #define for_each_tiling(__tiling) \
>>   	for (__tiling = T_LINEAR; __tiling < __BLT_MAX_TILING; __tiling++) 
>> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c index 
>> 34817f7b6..a669797c3 100644
>> --- a/lib/intel_device_info.c
>> +++ b/lib/intel_device_info.c
>> @@ -511,7 +511,7 @@ static const struct intel_device_info intel_lunarlake_info = {
>>   	.has_4tile = true,
>>   	.is_lunarlake = true,
>>   	.codename = "lunarlake",
>> -	.cmds_info = &gen12_pvc_cmds_info,
>> +	.cmds_info = &xe2_cmds_info,
>>   };
>>   
>>   static const struct pci_id_match intel_device_match[] = {