[i-g-t V6 02/10] tests/kms_vrr: Clear VRR before exit

Golani, Mitulkumar Ajitkumar mitulkumar.ajitkumar.golani at intel.com
Thu Dec 7 14:12:10 UTC 2023



> -----Original Message-----
> From: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>
> Sent: Thursday, December 7, 2023 12:19 PM
> To: igt-dev at lists.freedesktop.org; ville.syrjala at linux.intel.com; Golani,
> Mitulkumar Ajitkumar <mitulkumar.ajitkumar.golani at intel.com>
> Cc: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>
> Subject: [i-g-t V6 02/10] tests/kms_vrr: Clear VRR before exit
> 
> Before exiting the subtest, make sure to clear the VRR.
> 
> V2: - New function for cleanup
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> ---
>  tests/kms_vrr.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c index bbdb54682..13e7f3ca6
> 100644
> --- a/tests/kms_vrr.c
> +++ b/tests/kms_vrr.c
> @@ -469,8 +469,11 @@ test_basic(data_t *data, enum pipe pipe,
> igt_output_t *output, uint32_t flags)
>  	igt_assert_f(result < 10,
>  		     "Refresh rate (%u Hz) %"PRIu64"ns: Target VRR %s
> threshold exceeded, result was %u%%\n",
>  		     ((range.max + range.min) / 2), rate, (flags &
> TEST_NEGATIVE)? "on" : "off", result);
> +}
> 
> -	/* Clean-up */
> +static void test_cleanup(data_t *data, enum pipe pipe, igt_output_t
> +*output) {
> +	igt_pipe_set_prop_value(&data->display, pipe,
Change LGTM. Thanks

Reviewed-by: Mitul Golani <mitulkumar.ajitkumar.golani at intel.com>

> IGT_CRTC_VRR_ENABLED,
> +false);
>  	igt_plane_set_fb(data->primary, NULL);
>  	igt_output_set_pipe(output, PIPE_NONE);
>  	igt_output_override_mode(output, NULL); @@ -510,6 +513,9 @@
> run_vrr_test(data_t *data, test_t test, uint32_t flags)
>  				igt_dynamic_f("pipe-%s-%s",
>  					      kmstest_pipe_name(pipe),
> output->name)
>  					test(data, pipe, output, flags);
> +
> +				test_cleanup(data, pipe, output);
> +
>  				break;
>  			}
>  		}
> --
> 2.40.0



More information about the igt-dev mailing list