[PATCH] tests/kms_sysfs_edid_timing: increase thresholds

Kamil Konieczny kamil.konieczny at linux.intel.com
Mon Dec 11 12:44:44 UTC 2023


Hi Charlton,
On 2023-12-08 at 14:42:05 -0800, Charlton Lin wrote:

Please subscribe to igt-dev list, also when sending igt patches
add i-g-t after PATCH:

[PATCH i-g-t] tests/kms_sysfs_edid_timing: increase thresholds

> A customer panel consistently exceeds 150ms. Additionally, the
> timing may be impacted by certain power states.
> 
> Increase all thresholds to accommodate.
> 
> Cc: Sharma, Swati2 <swati2.sharma at intel.com>
----- ^^^^^^^^^^^^^^
This breaks your git send-email, correct is:

Cc: Swati Sharma <swati2.sharma at intel.com>

> Cc: Khaled Almahallawy <khaled.almahallawy at intel.com>
> Cc: Mark Yacoub <markyacoub at chromium.org>

I don't see this in header? Added to cc.

> Signed-off-by: Charlton Lin <charlton.lin at intel.com>
> ---
>  tests/kms_sysfs_edid_timing.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> index 775211089f81..582133ea002e 100644
> --- a/tests/kms_sysfs_edid_timing.c
> +++ b/tests/kms_sysfs_edid_timing.c
> @@ -26,9 +26,9 @@
>  #include <fcntl.h>
>  #include <sys/stat.h>
>  
> -#define THRESHOLD_PER_CONNECTOR		150
> -#define THRESHOLD_PER_CONNECTOR_MEAN	140
> -#define THRESHOLD_ALL_CONNECTORS_MEAN	100
> +#define THRESHOLD_PER_CONNECTOR		1500
> +#define THRESHOLD_PER_CONNECTOR_MEAN	1400
> +#define THRESHOLD_ALL_CONNECTORS_MEAN	1000

This is like increasing it ten times, add this to description.
I am not KMS nor panel expert but is it really that long?

Regards,
Kamil

>  #define CHECK_TIMES			15
>  
>  IGT_TEST_DESCRIPTION("This test checks the time it takes to reprobe each "
> -- 
> 2.25.1
> 


More information about the igt-dev mailing list