[PATCH i-g-t v4 4/6] lib/intel_blt: Update caching mode and pat_index

[Jahagirdar, Akshata]

-----Original Message-----
From: Kempczynski, Zbigniew <zbigniew.kempczynski at intel.com> 
Sent: Monday, December 11, 2023 1:17 AM
To: Jahagirdar, Akshata <akshata.jahagirdar at intel.com>
Cc: igt-dev at lists.freedesktop.org; Siddiqui, Ayaz A <ayaz.siddiqui at intel.com>; Stolarek, Karolina <karolina.stolarek at intel.com>; Auld, Matthew <matthew.auld at intel.com>; Mishra, Pallavi <pallavi.mishra at intel.com>
Subject: Re: [PATCH i-g-t v4 4/6] lib/intel_blt: Update caching mode and pat_index

On Thu, Dec 07, 2023 at 04:42:39AM -0800, Akshata Jahagirdar wrote:
> The pat-index and caching mode for compression need to change to 
> uc_comp in case of compression, else they just take the default value of pat_index.
> 
> Signed-off-by: Akshata Jahagirdar <akshata.jahagirdar at intel.com>
> ---
>  lib/intel_blt.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/intel_blt.c b/lib/intel_blt.c index 
> a2e64586b..d54b19340 100644
> --- a/lib/intel_blt.c
> +++ b/lib/intel_blt.c
> @@ -1796,7 +1796,8 @@ blt_create_object(const struct blt_copy_data *blt, uint32_t region,
>  	uint64_t size = width * height * bpp / 8;
>  	uint32_t stride = tiling == T_LINEAR ? width * 4 : width;
>  	uint32_t handle;
> -
> +	uint8_t pat_index = (AT_LEAST_GEN(intel_get_drm_devid(blt->fd), 20) 
> +&& compression) ? intel_get_pat_idx_uc_comp(blt->fd) : 
> +DEFAULT_PAT_INDEX;

Too long line - please refactor. AT_LEAST_GEN() is already protected by () and there's no need to add it here. With this fixed:

Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew

AJ: Sure, thanks. Will fix this!

> +	uint16_t cpu_caching = DRM_XE_GEM_CPU_CACHING_WC;
>  	igt_assert_f(blt->driver, "Driver isn't set, have you called 
> blt_copy_init()?\n");
>  
>  	obj = calloc(1, sizeof(*obj));
> @@ -1810,13 +1811,13 @@ blt_create_object(const struct blt_copy_data *blt, uint32_t region,
>  			flags |= DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM;
>  
>  		size = ALIGN(size, xe_get_default_alignment(blt->fd));
> -		handle = xe_bo_create_flags(blt->fd, 0, size, region);
> +		handle = xe_bo_create_caching(blt->fd, 0, size, region, flags, 
> +cpu_caching);
>  	} else {
>  		igt_assert(__gem_create_in_memory_regions(blt->fd, &handle,
>  							  &size, region) == 0);
>  	}
>  
> -	blt_set_object(obj, handle, size, region, mocs_index, DEFAULT_PAT_INDEX, tiling,
> +	blt_set_object(obj, handle, size, region, mocs_index, pat_index, 
> +tiling,
>  		       compression, compression_type);
>  	blt_set_geom(obj, stride, 0, 0, width, height, 0, 0);
>  
> --
> 2.34.1
>