[PATCH i-g-t] xe/tests: Remove tile_sysfs test for now

Kamil Konieczny kamil.konieczny at linux.intel.com
Tue Dec 12 08:27:06 UTC 2023


Hi Rodrigo,
On 2023-12-11 at 19:21:14 -0500, Rodrigo Vivi wrote:

Small nit about subject:
[PATCH i-g-t] xe/tests: Remove tile_sysfs test for now

should be:
[PATCH i-g-t] tests/xe: Remove tile_sysfs test for now

or better:
[PATCH i-g-t] tests/intel/xe_tile_sysfs: Remove it for now

With this fixed:
Acked-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

Regards,
Kamil

> The only case in this test was for the physical_memsize_attr
> that is getting removed from kernel. So, let's entirely remove
> this test case for now and re-add it when we have another reason.
> 
> Cc: Matt Roper <matthew.d.roper at intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
>  tests/intel/xe_sysfs_tile.c | 59 -------------------------------------
>  tests/meson.build           |  1 -
>  2 files changed, 60 deletions(-)
>  delete mode 100644 tests/intel/xe_sysfs_tile.c
> 
> diff --git a/tests/intel/xe_sysfs_tile.c b/tests/intel/xe_sysfs_tile.c
> deleted file mode 100644
> index ba970cda8..000000000
> --- a/tests/intel/xe_sysfs_tile.c
> +++ /dev/null
> @@ -1,59 +0,0 @@
> -// SPDX-License-Identifier: MIT
> -/*
> - * Copyright © 2023 Intel Corporation
> - */
> -
> -/**
> - * TEST: Verify physical_vram_size_bytes of each tiles
> - * Category: Software building block
> - * SUBTEST: physical_vram_size_bytes
> - * Functionality: Vram
> - * Sub-category: Total vram per tile
> - * Test category: functionality test
> - * Description:
> - *             Read sysfs entry for physical_vram_size_bytes and compare with
> - *             vram size. physical_vram_size_bytes should be more than vram size.
> - */
> -
> -#include <string.h>
> -#include <sys/time.h>
> -
> -#include "igt.h"
> -#include "igt_sysfs.h"
> -
> -#include "xe_drm.h"
> -#include "xe/xe_ioctl.h"
> -#include "xe/xe_query.h"
> -
> -static void test_vram_physical_vram_size_bytes(int tile_fd, int tile_num, u64 vram_size)
> -{
> -	u64 physical_vram_size_bytes;
> -
> -	igt_assert(igt_sysfs_scanf(tile_fd, "physical_vram_size_bytes",
> -				   "%lx", &physical_vram_size_bytes) > 0);
> -	igt_assert_lt_u64(vram_size, physical_vram_size_bytes);
> -}
> -
> -igt_main
> -{
> -	int fd, tilefd, tile;
> -	u64 vram_size;
> -
> -	igt_fixture {
> -		fd = drm_open_driver(DRIVER_XE);
> -		xe_device_get(fd);
> -	}
> -
> -	igt_subtest("physical_vram_size_bytes") {
> -		igt_require(xe_has_vram(fd));
> -		for_each_sysfs_tile_dirfd(fd, tilefd, tile) {
> -			vram_size = xe_vram_size(fd, tile);
> -			test_vram_physical_vram_size_bytes(tilefd, tile, vram_size);
> -		}
> -	}
> -
> -	igt_fixture {
> -		xe_device_put(fd);
> -		close(fd);
> -	}
> -}
> diff --git a/tests/meson.build b/tests/meson.build
> index f6cfbcf5e..4591ca256 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -307,7 +307,6 @@ intel_xe_progs = [
>  	'xe_prime_self_import',
>  	'xe_perf_pmu',
>  	'xe_query',
> -	'xe_sysfs_tile',
>  	'xe_uevent',
>  	'xe_vm',
>  	'xe_waitfence',
> -- 
> 2.43.0
> 


More information about the igt-dev mailing list