[PATCH i-g-t v5 5/6] tests/intel/gem_ccs: Add compression support for Lunarlake

[Jahagirdar, Akshata]

-----Original Message-----
From: Auld, Matthew <matthew.auld at intel.com> 
Sent: Tuesday, December 12, 2023 1:32 AM
To: Jahagirdar, Akshata <akshata.jahagirdar at intel.com>
Cc: igt-dev at lists.freedesktop.org; Siddiqui, Ayaz A <ayaz.siddiqui at intel.com>; Stolarek, Karolina <karolina.stolarek at intel.com>; Kempczynski, Zbigniew <zbigniew.kempczynski at intel.com>; Mishra, Pallavi <pallavi.mishra at intel.com>; kamil.konieczny at linux.intel.com
Subject: Re: [PATCH i-g-t v5 5/6] tests/intel/gem_ccs: Add compression support for Lunarlake

On 12/12/2023 17:39, Akshata Jahagirdar wrote:
> Update the ccs_ratio call to get value according to platform.
> 
> Signed-off-by: Akshata Jahagirdar <akshata.jahagirdar at intel.com>
> ---
>   tests/intel/gem_ccs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/intel/gem_ccs.c b/tests/intel/gem_ccs.c index 
> 0a691778d..5a17be4cb 100644
> --- a/tests/intel/gem_ccs.c
> +++ b/tests/intel/gem_ccs.c
> @@ -99,7 +99,7 @@ static void surf_copy(int i915,
>   	struct blt_block_copy_data_ext ext = {};
>   	struct blt_ctrl_surf_copy_data surf = {};
>   	uint32_t bb1, bb2, ccs, ccs2, *ccsmap, *ccsmap2;
> -	uint64_t bb_size, ccssize = mid->size / CCS_RATIO;
> +	uint64_t bb_size, ccssize = mid->size / (CCS_RATIO(i915));

This seems misplaced, should this rather be squashed into one of the previous patches? CCS_RATIO now takes an argument, but that was done earlier in the series.

AJ: Sure, I kept it separately since this change is respective to this particular test.
But, I understand there would be compilation error for earlier patches , will make this change in the same previous patch.

Also, can you please take a look at the last patch in the series (xe_ccs test changes) and provide your insights? Would be really helpful.
Thank you.

>   	uint32_t *ccscopy;
>   	uint8_t uc_mocs = intel_get_uc_mocs_index(i915);
>   	int result;