[PATCH i-g-t] intel/xe_exec_store: Add Persistent subtest

[Kumar, Janga Rahul]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of
> sai.gowtham.ch at intel.com
> Sent: Wednesday, December 13, 2023 6:29 PM
> To: igt-dev at lists.freedesktop.org; Ch, Sai Gowtham
> <sai.gowtham.ch at intel.com>
> Subject: [PATCH i-g-t] intel/xe_exec_store: Add Persistent subtest
> 
> From: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
> 
> Add persistent subtest to validate MI_PRT_BATCH_BUFFER_START.
> 
> Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
> ---
>  tests/intel/xe_exec_store.c | 87
> +++++++++++++++++++++++++++++++++++++
>  1 file changed, 87 insertions(+)
> 
> diff --git a/tests/intel/xe_exec_store.c b/tests/intel/xe_exec_store.c index
> 7a66d744c..ea7ecb01f 100644
> --- a/tests/intel/xe_exec_store.c
> +++ b/tests/intel/xe_exec_store.c
> @@ -23,6 +23,7 @@
>  #define MAX_INSTANCE 9
>  #define STORE 0
>  #define COND_BATCH 1
> +#define MI_PRT_BATCH_BUFFER_START (0x39 << 23)
Move this command to a library

> 
>  struct data {
>  	uint32_t batch[16];
> @@ -74,6 +75,24 @@ static void cond_batch(struct data *data, uint64_t
> addr, int value)
>  	data->addr = batch_addr;
>  }
> 
> +static void persistance_batch(struct data *data, uint64_t addr) {
> +	int b;
> +	uint64_t batch_offset = (char *)&(data->batch) - (char *)data;
> +	uint64_t batch_addr = addr + batch_offset;
> +	uint64_t sdi_offset = (char *)&(data->data) - (char *)data;
> +	uint64_t sdi_addr = addr + sdi_offset;
Rename sdi_offset/addr as they no longer represent store dword addr but a persistent batch buffer addr.
> +
> +	b = 0;
> +	data->batch[b++] = MI_BATCH_BUFFER_START;
> +	data->batch[b++] = MI_PRT_BATCH_BUFFER_START;
> +	data->batch[b++] = sdi_addr;
> +	data->batch[b++] = sdi_addr >> 32;
> +	data->batch[b++] = MI_BATCH_BUFFER_END;
> +
> +	data->addr = batch_addr;
> +
> +}
>  /**
>   * SUBTEST: basic-store
>   * Description: Basic test to verify store dword.
> @@ -246,6 +265,71 @@ static void store_cachelines(int fd, struct
> drm_xe_engine_class_instance *eci,
>  	xe_vm_destroy(fd, vm);
>  }
> 
> +/**
> + * SUBTEST: persistent
> + * DESCRIPTION: Validate MI_PRT_BATCH_BUFFER_START functionality  */
> +static void persistent(int fd) {
> +	struct drm_xe_sync sync = {
> +		.type = DRM_XE_SYNC_TYPE_SYNCOBJ,
> +		.flags = DRM_XE_SYNC_FLAG_SIGNAL,
> +	};
> +	struct drm_xe_exec exec = {
> +		.num_batch_buffer = 1,
> +		.num_syncs = 1,
> +		.syncs = to_user_pointer(&sync),
> +	};
> +	struct data *data1;
> +	struct data *data2;
> +	struct drm_xe_engine *engine;
> +	uint32_t vm, exec_queue,syncobj;
> +	uint32_t batch1, batch2;
Rename data1, data2, batch1 and batch2 to represent what are they intended for ?

Thanks,
Rahul
> +	uint64_t addr = 0x100000;
> +	int value = 0x123456;
> +	size_t batch_size = 4096;
> +
> +	syncobj = syncobj_create(fd, 0);
> +	sync.handle = syncobj;
> +
> +	vm = xe_vm_create(fd,
> DRM_XE_VM_CREATE_FLAG_ASYNC_DEFAULT, 0);
> +	batch_size = ALIGN(batch_size + xe_cs_prefetch_size(fd),
> +					xe_get_default_alignment(fd));
> +
> +	engine = xe_engine(fd, 1);
> +	batch1 = xe_bo_create(fd, vm, batch_size,
> +			      vram_if_possible(fd, engine->instance.gt_id),
> +
> DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
> +	batch2 = xe_bo_create(fd, vm, batch_size,
> +			      vram_if_possible(fd, engine->instance.gt_id),
> +
> DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
> +
> +	xe_vm_bind_async(fd, vm, engine->instance.gt_id, batch1, 0, addr,
> batch_size, &sync, 1);
> +	data1 = xe_bo_map(fd, batch1, batch_size);
> +	data2 = xe_bo_map(fd, batch2, batch_size);
> +
> +	store_dword_batch(data1, addr, value);
Persistent batch buffer should not contain MI_BATCH_BUFFER_START , you might have to rewrite a new helper to create store dword batch without MI_BATCH_BUFFER_START.

Thanks,
Rahul
> +	persistance_batch(data2, addr);
> +
> +	exec_queue = xe_exec_queue_create(fd, vm, &engine->instance,
> 0);
> +	exec.exec_queue_id = exec_queue;
> +	exec.address = data2->addr;
> +	sync.flags &= DRM_XE_SYNC_FLAG_SIGNAL;
> +	xe_exec(fd, &exec);
> +
> +	igt_assert(syncobj_wait(fd, &syncobj, 1, INT64_MAX, 0, NULL));
> +	igt_assert_eq(data1->data, value);
> +
> +	syncobj_destroy(fd, syncobj);
> +	munmap(data1, batch_size);
> +	munmap(data2, batch_size);
> +	gem_close(fd, batch1);
> +	gem_close(fd, batch2);
> +
> +	xe_exec_queue_destroy(fd, exec_queue);
> +	xe_vm_destroy(fd, vm);
> +}
> +
>  igt_main
>  {
>  	struct drm_xe_engine_class_instance *hwe; @@ -285,6 +369,9 @@
> igt_main
>  		xe_for_each_engine(fd, hwe)
>  			store_cachelines(fd, hwe, PAGES);
> 
> +	igt_subtest("persistent")
> +		persistent(fd);
> +
>  	igt_fixture {
>  		xe_device_put(fd);
>  		close(fd);
> --
> 2.39.1