[PATCH] lib: sync i915_pciids.h with kernel

Kamil Konieczny kamil.konieczny at linux.intel.com
Mon Dec 18 16:19:18 UTC 2023


Hi,

On 2023-12-18 at 10:14:34 +0000, Borah, Chaitanya Kumar wrote:
> Hello Kamil,
> 
> > -----Original Message-----
> > From: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> > Sent: Thursday, December 14, 2023 8:06 PM
> > To: igt-dev at lists.freedesktop.org
> > Cc: Borah, Chaitanya Kumar <chaitanya.kumar.borah at intel.com>; Juha-Pekka
> > Heikkila <juhapekka.heikkila at gmail.com>; Garg, Nemesa
> > <nemesa.garg at intel.com>
> > Subject: Re: [PATCH] lib: sync i915_pciids.h with kernel
> > 
> > Hi,
> > 
> > On 2023-12-14 at 04:48:27 +0000, Borah, Chaitanya Kumar wrote:
> > > Hello JP,
> > >
> > > > -----Original Message-----
> > > > From: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> > > > Sent: Wednesday, December 13, 2023 6:47 PM
> > > > To: Borah, Chaitanya Kumar <chaitanya.kumar.borah at intel.com>; igt-
> > > > dev at lists.freedesktop.org
> > > > Cc: Garg, Nemesa <nemesa.garg at intel.com>
> > > > Subject: Re: [PATCH] lib: sync i915_pciids.h with kernel
> > > >
> > > > This is not correct. This does not synchronize with kernel commit.
> > > > i915_pciids.h is supposed to be copied as is from kernel.
> > >
> > > This has crossed my mind but there are a lot of changes[1] unrelated to
> > ARL-S if we just copy the file.
> > > Therefore, it made me a bit uncomfortable. Should I go ahead anyway?
> > >
> > > At least for PVC device ids, we might have to take an exception. Or may be
> > they did not belong there in the first place.
> > >
> > 
> > You may add only ARL-S but then write in subject what you did as it is not
> > syncing, for example:
> > 
> > [PATCH] lib/i915_pciids: Add ARL-S
> > 
> > and describe why you added only that. Write also which commit (hash and
> > subject) you used (working link could also help).
> > 
> > One more thing: why not adding all without removing PVC ids?
> > 
> 
> Actually, I will go ahead and do that. I will post a patch soon.
> 
> Regards
> 
> Chaitanya

Last thing, please add i-g-t in subject after PATCH, so it will be:

[PATCH i-g-t] describe here your patch

Regards,
Kamil

[...cut...]



More information about the igt-dev mailing list