[PATCH i-g-t 3/3] tests/kms_async_flips: test with modifiers only on intel devices

Melissa Wen mwen at igalia.com
Tue Dec 26 18:57:34 UTC 2023


Although increasing the coverage of tests with modifiers, the change
from run_test() to run_test_with_modifiers() is now a regression on
non-intel devices. run_test_with_modifiers() only ensures conditions for
modifiers != LINEAR on intel devices, and the original run_test() is
more consistent across vendors.

Signed-off-by: Melissa Wen <mwen at igalia.com>
---
 tests/kms_async_flips.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index 6fddad093..55d59196e 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -654,7 +654,10 @@ igt_main
 		igt_describe("Wait for page flip events in between successive asynchronous flips");
 		igt_subtest_with_dynamic("async-flip-with-page-flip-events") {
 			data.alternate_sync_async = false;
-			run_test_with_modifiers(&data, test_async_flip);
+			if (is_intel_device(data.drm_fd))
+				run_test_with_modifiers(&data, test_async_flip);
+			else
+				run_test(&data, test_async_flip);
 		}
 
 		igt_describe("Alternate between sync and async flips");
-- 
2.43.0



More information about the igt-dev mailing list