[igt-dev] [PATCH i-g-t 0/1] Fix IGT runner error logic when listing subtests

Mauro Carvalho Chehab mauro.chehab at linux.intel.com
Mon Feb 20 09:20:04 UTC 2023


From: Mauro Carvalho Chehab <mchehab at kernel.org>

Patches may end breaking --list-subtests if they, for instance, have a
pattern like:

	igt_fixture
		fd = drm_open_driver(DRIVER);
	...
	do_something(fd);

	igt_subtest("foo")
		...
	igt_subtest("bar")
		...

As any usage of (fd) will cause a crash. As result, currently IGT
will produce stderror outbut, but will keep executing, producing
a wrong testlist, as "foo" and "bar" won't be listed.

That will also break scripts that would depend on a reliable testlist.

So, return an error on such cases.

Mauro Carvalho Chehab (1):
  runner/job_list: return error on crashes while running --list-subtests

 runner/job_list.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.39.0



More information about the igt-dev mailing list