[igt-dev] [PATCH i-g-t 2/2] tests/kms_vblank: no need to clear black with black

Ville Syrjälä ville.syrjala at linux.intel.com
Mon Feb 27 11:39:18 UTC 2023


On Mon, Feb 27, 2023 at 01:32:27PM +0200, Juha-Pekka Heikkila wrote:
> created framebuffer was uselessly painted black which just wasted
> time from ci.
> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

For the series:
Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

> ---
>  tests/kms_vblank.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> index 5bd3fefe1..b6c1c7c42 100644
> --- a/tests/kms_vblank.c
> +++ b/tests/kms_vblank.c
> @@ -79,11 +79,10 @@ static void prepare_crtc(data_t *data, int fd, igt_output_t *output)
>  
>  	/* create and set the primary plane fb */
>  	mode = igt_output_get_mode(output);
> -	igt_create_color_fb(fd, mode->hdisplay, mode->vdisplay,
> -			    DRM_FORMAT_XRGB8888,
> -			    DRM_FORMAT_MOD_LINEAR,
> -			    0.0, 0.0, 0.0,
> -			    &data->primary_fb);
> +	igt_create_fb(fd, mode->hdisplay, mode->vdisplay,
> +		      DRM_FORMAT_XRGB8888,
> +		      DRM_FORMAT_MOD_LINEAR,
> +		      &data->primary_fb);
>  
>  	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
>  	igt_plane_set_fb(primary, &data->primary_fb);
> -- 
> 2.39.0

-- 
Ville Syrjälä
Intel


More information about the igt-dev mailing list