[igt-dev] [i-g-t] tests/kms_cursor_crc: Add Gaurd for MSO eDP for Pipe C and D

[Bhadane, Dnyaneshwar]

Hi Swati,

> -----Original Message-----
> From: Sharma, Swati2 <swati2.sharma at intel.com>
> Sent: Saturday, December 31, 2022 12:46 AM
> To: Bhadane, Dnyaneshwar <dnyaneshwar.bhadane at intel.com>; igt-
> dev at lists.freedesktop.org
> Cc: Kurmi, Suresh Kumar <suresh.kumar.kurmi at intel.com>; Shankar, Uma
> <uma.shankar at intel.com>; Modem, Bhanuprakash
> <bhanuprakash.modem at intel.com>; Borah, Chaitanya Kumar
> <chaitanya.kumar.borah at intel.com>; B, Jeevan <jeevan.b at intel.com>
> Subject: Re: [i-g-t] tests/kms_cursor_crc: Add Gaurd for MSO eDP for Pipe C
> and D
>
>
>
> On 30-Dec-22 12:16 PM, bhadanednyaneshwar wrote:
> > MSO eDP is not supported on pipe C and D. Added a test condition to
> > prevent tests from execution on pipe C and D.This condition was missed
> > for cursor-size-change,cursor-alpha-opaque and
> > cursor-alpha-transparent testcases.
> >
> > Inside require_cursor_size() checks first for eligiblity to igt commit
> > using test buffer.For MSO eDP, It is fail to commit for pipe C/pipe D
> > and require_cursor_size() return non zero value. So it will skip the
> > dynamic testcase for pipe C and D.
> >
> > Signed-off-by: bhadanednyaneshwar <dnyaneshwar.bhadane at intel.com>
> > ---
> >   tests/kms_cursor_crc.c | 21 ++++++++++++++++++---
> >   1 file changed, 18 insertions(+), 3 deletions(-)
> >
> > diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index
> > 17f294d6..d8fb9c0d 100644
> > --- a/tests/kms_cursor_crc.c
> > +++ b/tests/kms_cursor_crc.c
> > @@ -786,7 +786,12 @@ static void run_tests_on_pipe(data_t *data)
> >     igt_subtest_with_dynamic("cursor-size-change") {
> >             for_each_pipe(&data->display, pipe) {
> >                     data->pipe = pipe;
> > -
> > +                   create_cursor_fb(data, data->cursor_max_w, data-
> >cursor_max_h);
>  >> Instead of creating cursor_fb in each function, we can have igt_fixture {
>       create_cursor_fb(data, data->cursor_max_w, data->cursor_max_h); }
> moved up and only have if (require_cursor_size()) check in each subtest.

For every pipe the we require to create_cursor_fb()  because the testcase
closing the buffer using igt_remove_fb() on every pipe in the loop;
So igt_fixture { create_cursor_fb() } will only called once, but we need to
create buffer on every pipe in the loop.
>
> > +                   if (require_cursor_size(data, data->cursor_max_w,
> data->cursor_max_h)) {
> > +                           igt_debug("Cursor size %dx%d not supported
> by driver\n",
> > +                                     data->cursor_max_w, data-
> >cursor_max_h);
> > +                           continue;
> > +                   }
> >                     igt_dynamic_f("pipe-%s-%s",
> >                                   kmstest_pipe_name(pipe),
> >                                   data->output->name)
> > @@ -800,7 +805,12 @@ static void run_tests_on_pipe(data_t *data)
> >     igt_subtest_with_dynamic("cursor-alpha-opaque") {
> >             for_each_pipe(&data->display, pipe) {
> >                     data->pipe = pipe;
> > -
> > +                   create_cursor_fb(data, data->cursor_max_w, data-
> >cursor_max_h);
> > +                   if (require_cursor_size(data, data->cursor_max_w,
> data->cursor_max_h)) {
> > +                           igt_debug("Cursor size %dx%d not supported
> by driver\n",
> > +                                     data->cursor_max_w, data-
> >cursor_max_h);
> > +                           continue;
> > +                   }
> >                     igt_dynamic_f("pipe-%s-%s",
> >                                   kmstest_pipe_name(pipe),
> >                                   data->output->name)
> > @@ -814,7 +824,12 @@ static void run_tests_on_pipe(data_t *data)
> >     igt_subtest_with_dynamic("cursor-alpha-transparent") {
> >             for_each_pipe(&data->display, pipe) {
> >                     data->pipe = pipe;
> > -
> > +                   create_cursor_fb(data, data->cursor_max_w, data-
> >cursor_max_h);
> > +                   if (require_cursor_size(data, data->cursor_max_w,
> data->cursor_max_h)) {
> > +                           igt_debug("Cursor size %dx%d not supported
> by driver\n",
> > +                                     data->cursor_max_w, data-
> >cursor_max_h);
> > +                           continue;
> > +                   }
> >                     igt_dynamic_f("pipe-%s-%s",
> >                                   kmstest_pipe_name(pipe),
> >                                   data->output->name)
>
> --
> ~Swati Sharma