[igt-dev] [PATCH 1/4] lib/amdgpu: rename function parameter
Christian König
christian.koenig at amd.com
Thu Jan 5 09:22:19 UTC 2023
Reviewed-by: Christian König <christian.koenig at amd.com> for patch #1 and #2.
Acked-by: Christian König <christian.koenig at amd.com> fro patch #3 and #4.
Thanks,
Christian.
Am 05.01.23 um 01:53 schrieb vitaly.prosyak at amd.com:
> From: Vitaly Prosyak <vitaly.prosyak at amd.com>
>
> No functional change just cosmetic.
> Rename flags parameter to alloc_flags for clarity.
> There are mapping flags.
>
> Signed-off-by: Vitaly Prosyak <vitaly.prosyak at amd.com>
> ---
> lib/amdgpu/amd_memory.c | 10 ++++------
> lib/amdgpu/amd_memory.h | 2 +-
> 2 files changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/lib/amdgpu/amd_memory.c b/lib/amdgpu/amd_memory.c
> index 0aa400ac8..e3432a954 100644
> --- a/lib/amdgpu/amd_memory.c
> +++ b/lib/amdgpu/amd_memory.c
> @@ -41,7 +41,7 @@
> uint64_t size,
> uint64_t alignment,
> uint32_t type,
> - uint64_t flags,
> + uint64_t alloc_flags,
> uint64_t *vmc_addr,
> amdgpu_va_handle *va_handle)
> {
> @@ -49,7 +49,7 @@
> .alloc_size = size,
> .phys_alignment = alignment,
> .preferred_heap = type,
> - .flags = flags,
> + .flags = alloc_flags,
> };
> amdgpu_bo_handle buf_handle;
> int r;
> @@ -57,10 +57,8 @@
> r = amdgpu_bo_alloc(device_handle, &req, &buf_handle);
> igt_assert_eq(r, 0);
>
> - r = amdgpu_va_range_alloc(device_handle,
> - amdgpu_gpu_va_range_general,
> - size, alignment, 0, vmc_addr,
> - va_handle, 0);
> + r = amdgpu_va_range_alloc(device_handle, amdgpu_gpu_va_range_general,
> + size, alignment, 0, vmc_addr, va_handle, 0);
> igt_assert_eq(r, 0);
>
> r = amdgpu_bo_va_op(buf_handle, 0, size, *vmc_addr, 0, AMDGPU_VA_OP_MAP);
> diff --git a/lib/amdgpu/amd_memory.h b/lib/amdgpu/amd_memory.h
> index 77fd099b0..a06f88923 100644
> --- a/lib/amdgpu/amd_memory.h
> +++ b/lib/amdgpu/amd_memory.h
> @@ -35,7 +35,7 @@ gpu_mem_alloc(amdgpu_device_handle device_handle,
> uint64_t size,
> uint64_t alignment,
> uint32_t type,
> - uint64_t flags,
> + uint64_t alloc_flags,
> uint64_t *vmc_addr,
> amdgpu_va_handle *va_handle);
> int
More information about the igt-dev
mailing list