[igt-dev] [i-g-t v2] tests/kms_cursor_crc: Skip for invalid pipe connector connection

Dnyaneshwar Bhadane dnyaneshwar.bhadane at intel.com
Mon Jan 9 06:49:05 UTC 2023


Added a skip condition that checks for the valid pipe connection. This is a 
generic skip on pipe which checks for valid connector connection mask bit. 
This condition helps to skip tests for MSO panels on non supported pipes
(C and D).This condition was missed for cursor-size-change,
cursor-alpha-opaque and cursor-alpha-transparent testcases.

--v2
- Change commit messege  from "Add Gaurd for MSO eDP for Pipe C and D"
to "Skip condition for non valid pipe connector connection" [Kamil]
- skip condition using igt_pipe_connector_valid() [Juha-Pekka]

Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane at intel.com>

---
 tests/kms_cursor_crc.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index 17f294d6..87497b9e 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -786,6 +786,13 @@ static void run_tests_on_pipe(data_t *data)
 	igt_subtest_with_dynamic("cursor-size-change") {
 		for_each_pipe(&data->display, pipe) {
 			data->pipe = pipe;
+			
+			if(!igt_pipe_connector_valid(pipe, data->output)) {
+				igt_debug("Invalid connector on pipe-%s-%s",
+				      kmstest_pipe_name(pipe),
+				      data->output->name);
+				continue;
+			}
 
 			igt_dynamic_f("pipe-%s-%s",
 				      kmstest_pipe_name(pipe),
@@ -800,6 +807,13 @@ static void run_tests_on_pipe(data_t *data)
 	igt_subtest_with_dynamic("cursor-alpha-opaque") {
 		for_each_pipe(&data->display, pipe) {
 			data->pipe = pipe;
+			
+			if(!igt_pipe_connector_valid(pipe, data->output)) {
+				igt_debug("Invalid connector on pipe-%s-%s",
+				      kmstest_pipe_name(pipe),
+				      data->output->name);
+				continue;
+			}
 
 			igt_dynamic_f("pipe-%s-%s",
 				      kmstest_pipe_name(pipe),
@@ -814,6 +828,13 @@ static void run_tests_on_pipe(data_t *data)
 	igt_subtest_with_dynamic("cursor-alpha-transparent") {
 		for_each_pipe(&data->display, pipe) {
 			data->pipe = pipe;
+			
+			if(!igt_pipe_connector_valid(pipe, data->output)) {
+				igt_debug("Invalid connector on pipe-%s-%s",
+				      kmstest_pipe_name(pipe),
+				      data->output->name);
+				continue;
+			}
 
 			igt_dynamic_f("pipe-%s-%s",
 				      kmstest_pipe_name(pipe),
-- 
2.35.1



More information about the igt-dev mailing list