[igt-dev] [PATCH i-g-t v2 3/6] lib/i915_blt: Check for Tile-YF in fast_copy

[Zbigniew Kempczyński]

On Fri, Dec 23, 2022 at 12:13:48PM +0100, Karolina Stolarek wrote:
> In older gens Tile4 is not available, we have Tile-YF instead. Check for
> both tilings when setting up the fast_copy command.
> 
> Signed-off-by: Karolina Stolarek <karolina.stolarek at intel.com>
> ---
>  lib/i915/i915_blt.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
> index 00cf7470..23ee2218 100644
> --- a/lib/i915/i915_blt.c
> +++ b/lib/i915/i915_blt.c
> @@ -327,6 +327,11 @@ static enum blt_aux_mode __aux_mode(const struct blt_copy_object *obj)
>  	return AM_AUX_NONE;
>  }
>  
> +static bool __new_tile_y_type(enum blt_tiling_type tiling)
> +{
> +	return tiling == T_TILE4 || tiling == T_YFMAJOR;
> +}
> +
>  static void fill_data(struct gen12_block_copy_data *data,
>  		      const struct blt_copy_data *blt,
>  		      uint64_t src_offset, uint64_t dst_offset,
> @@ -1013,8 +1018,8 @@ uint64_t emit_blt_fast_copy(int i915,
>  	data.dw01.color_depth = __fast_color_depth(blt->color_depth);
>  	data.dw01.dst_memory = __memory_type(blt->dst.region);
>  	data.dw01.src_memory = __memory_type(blt->src.region);
> -	data.dw01.dst_type_y = blt->dst.tiling == T_TILE4 ? 1 : 0;
> -	data.dw01.src_type_y = blt->src.tiling == T_TILE4 ? 1 : 0;
> +	data.dw01.dst_type_y = __new_tile_y_type(blt->dst.tiling) ? 1 : 0;
> +	data.dw01.src_type_y = __new_tile_y_type(blt->src.tiling) ? 1 : 0;

Looks ok for me,

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew

>  
>  	data.dw02.dst_x1 = blt->dst.x1;
>  	data.dw02.dst_y1 = blt->dst.y1;
> -- 
> 2.25.1
>