[igt-dev] [PATCH i-g-t v3 0/6] Introduce blt_cmd_info struct
Karolina Stolarek
karolina.stolarek at intel.com
Wed Jan 11 08:44:12 UTC 2023
This patch series introduces a new way of checking if a specific
tiling format and/or blitter copy command is supported on
the current platform. Instead of using functions with hardcoded
devices, now we store information about available features in
blt_cmd_info struct, each of the instances connected to the
intel_device_info definitions.
Two patches that follow the introduction of blt_cmd_info and
intel_device_info modification are a prep work for the fast
copy test -- extracting needed functions and updating
fill_data() to support TileYF (available only for Pre-gen12).
In addition to this, the patchset adds two fast copy tests: basic
fast-copy where two blit copies are done in separate batches, and
fast-copy-emit which uses emit_blt_fast_copy() and manually
crafts two copies in one batch.
v3 builds on the changes introduced in v2 and changes how
blt_tiling_type is defined. Now it's a contiguous enum, and the flags
used in .supported_tiling are built with a bit macro on the fly.
v3:
- Rewrite blt_tiling_type to be contiguous (Zbigniew, Kamil)
- Add BLT_BIT macro to create bit flags during .supported_tiling
field initialization (Zbigniew)
- Undo accidental line deletion in intel_chipset.c (Kamil)
- Add __TILING_MAX to blt_tiling_type (Zbigniew)
- Use asprintf when creating strings of subtest and PNG files
names (Zbigniew)
- Delete a duplicate WRITE_PNG call in fast_copy test (Zbigniew)
- Update documentation
- Update year in copyright headers
v2:
- Add documentation
- Rename blt_tiling to intel_blt_info to better capture the
nature of the library (Zbigniew)
- Rename "can" predicates for blitter commands to use "has"
(Kamil)
- Add a fast copy test with two copies in the same batch buffer
- Add blt_ prefixes to functions extracted from gem_ccs to
avoid name clash (Zbigniew/Kamil)
- Also move set_object_ext() out from gem_ccs so it can be
shared with other tests
- Significantly rewrite intel_blt_info library -- now it only
exposes blt_cmd_supports_tiling and blt_supports_command
and blt_cmd_info definitions that can be used by other
blitter libraries like i915_blt.
- Split introduction of intel_blt_info and usage of the struct
into two commits
- Add functions checking fast and block copy support to
i915_blt library
- Add reference to blt_cmd_info to intel_device_info definitions
(Zbigniew)
- Update commit messages (Kamil)
Karolina Stolarek (6):
i915/lib: Add new library for blitter and tiling formats
lib: Update platform definitions with blitter information
lib/i915_blt: Check for Tile-YF in fast_copy
lib/i915_blt: Add common functions for blt_copy_object
tests/gem_exercise_blt: Add fast-copy test
tests/gem_exercise_blt: Add fast-copy-emit test
.../igt-gpu-tools/igt-gpu-tools-docs.xml | 1 +
lib/i915/i915_blt.c | 195 +++++++--
lib/i915/i915_blt.h | 48 ++-
lib/i915/intel_blt_info.c | 248 +++++++++++
lib/i915/intel_blt_info.h | 96 +++++
lib/intel_chipset.h | 4 +
lib/intel_device_info.c | 47 +++
lib/meson.build | 1 +
tests/i915/gem_ccs.c | 209 +++-------
tests/i915/gem_exercise_blt.c | 387 ++++++++++++++++++
tests/i915/gem_lmem_swapping.c | 81 +---
tests/meson.build | 1 +
12 files changed, 1055 insertions(+), 263 deletions(-)
create mode 100644 lib/i915/intel_blt_info.c
create mode 100644 lib/i915/intel_blt_info.h
create mode 100644 tests/i915/gem_exercise_blt.c
--
2.25.1
More information about the igt-dev
mailing list