[igt-dev] [PATCH i-g-t 2/2] meson.build: Remove -fcommon flag

[Zbigniew Kempczyński]

On Mon, Jan 16, 2023 at 11:30:50AM +0200, Petri Latvala wrote:
> On Fri, Jan 13, 2023 at 08:25:53PM +0100, Zbigniew Kempczyński wrote:
> > Ensure global variables are explicitly defined in one place and
> > requires importing via extern keyword instead of duplicating definition
> > resolved during linking time.
> > 
> > Details: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85678
> > 
> > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> > Cc: Petri Latvala <petri.latvala at intel.com>
> > Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> 
> Reviewed-by: Petri Latvala <petri.latvala at intel.com>

Thanks, I've merged the series.

Do you need to bump igt version to 1.28? 

--
Zbigniew 

> 
> > ---
> >  meson.build | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/meson.build b/meson.build
> > index bbe1f673e8..7b25627229 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -70,7 +70,6 @@ cc_args = [
> >  # well with longjmp which is heavily used by IGT framework.
> >  	'-fno-builtin-malloc',
> >  	'-fno-builtin-calloc',
> > -	'-fcommon',
> >  ]
> >  
> >  foreach cc_arg : cc_args
> > -- 
> > 2.34.1
> >