[igt-dev] [PATCH i-g-t] i915/gem_create: Ensure newly created handles are not reusing same offset

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed Jan 18 12:45:21 UTC 2023


On 2023-01-17 at 15:49:23 +0100, Zbigniew Kempczyński wrote:
> We need to ensure second group of spinners won't stuck on vma eviction
> and they will be scheduled for the execution. We need to propose new
> offsets to avoid situation spinner batch and object dependency handle
> offset will overlap. Since reloc allocator is tracking offsets for
> handles we need to explicitly release it.
> 
> Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/7679
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  tests/i915/gem_create.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
> index af530ccc2f..c719ab6c77 100644
> --- a/tests/i915/gem_create.c
> +++ b/tests/i915/gem_create.c
> @@ -325,6 +325,7 @@ static void busy_create(int i915, const struct gem_memory_region *r, int timeout
>  					      .flags = ((flags & BUSY_HOG ? IGT_SPIN_NO_PREEMPTION : 0) |
>  							IGT_SPIN_SOFTDEP));
>  			gem_close(i915, handle);
> +			put_offset(ahnd, handle);
>  
>  			igt_spin_free(i915, spin[e->flags]);
>  			spin[e->flags] = next;
> -- 
> 2.34.1
> 


More information about the igt-dev mailing list