[igt-dev] [PATCH v4 1/4] lib/igt_sysfs: Add support to query number of tiles

[Ghimiray, Himal Prasad]

> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit at intel.com>
> Sent: 01 July 2023 22:39
> To: Ghimiray, Himal Prasad <himal.prasad.ghimiray at intel.com>
> Cc: igt-dev at lists.freedesktop.org; Upadhyay, Tejas
> <tejas.upadhyay at intel.com>; Kamil Konieczny
> <kamil.konieczny at linux.intel.com>
> Subject: Re: [igt-dev] [PATCH v4 1/4] lib/igt_sysfs: Add support to query
> number of tiles
> 
> On Tue, 27 Jun 2023 11:08:02 -0700, Himal Prasad Ghimiray wrote:
> >
> 
> Hi Himal,
> 
> > diff --git a/lib/igt_sysfs.h b/lib/igt_sysfs.h index
> > 978b6906..de2c9a86 100644
> > --- a/lib/igt_sysfs.h
> > +++ b/lib/igt_sysfs.h
> > @@ -38,6 +38,11 @@
> >	     (dirfd__ = igt_sysfs_gt_open(i915__, gt__)) != -1; \
> >	     close(dirfd__), gt__++)
> >
> > +#define for_each_sysfs_tile_dirfd(xe__, tile__, tile_cnt__) \
> > +	for (tile__ = 0, tile_cnt__ = igt_sysfs_get_num_tiles(xe__); \
> > +	     tile__ < tile_cnt__; \
> > +	     ++tile__)
> > +
> 
> You did not answer the question I asked previously about this:
> 
> "Where is dirfd here which should be a fd to an open sysfs directory as in
> for_each_sysfs_gt_dirfd?"
> 
> >  #define i915_for_each_gt for_each_sysfs_gt_dirfd
> 
> >
> >  #define igt_sysfs_rps_write(dir, id, data, len) \  @@ -73,6 +78,8 @@
> >  #define igt_sysfs_rps_set_boolean(dir, id, value) \
> >	igt_sysfs_set_boolean(dir, igt_sysfs_dir_id_to_name(dir, id), value)
> >
> > +#define xe_for_each_tile for_each_sysfs_tile_dirfd
> 
> I think let's just do this and get rid of for_each_sysfs_tile_dirfd:
> 
> #define xe_for_each_tile(xe__, tile__, tile_cnt__) \
> 	for (tile__ = 0, tile_cnt__ = igt_sysfs_get_num_tiles(xe__); \
> 	     tile__ < tile_cnt__; \
> 	     ++tile__)
> 
Agreed. Will address in next patch.
> > +
> >  enum i915_attr_id {
> >	RPS_ACT_FREQ_MHZ,
> >	RPS_CUR_FREQ_MHZ,
> > @@ -97,6 +104,7 @@ int igt_sysfs_open(int device);
> >  char *igt_sysfs_gt_path(int device, int gt, char *path, int pathlen);
> >  int igt_sysfs_gt_open(int device, int gt);
> >  int igt_sysfs_get_num_gt(int device);
> > +int igt_sysfs_get_num_tiles(int device);
> >  bool igt_sysfs_has_attr(int dir, const char *attr);  const char
> > *igt_sysfs_dir_id_to_name(int dir, enum i915_attr_id id);  const char
> > *igt_sysfs_path_id_to_name(const char *path, enum i915_attr_id id);
> > --
> > 2.25.1
> >