[igt-dev] [PATCH i-g-t v2 02/16] lib/intel_allocator: Drop aliasing allocator handle api

[Karolina Stolarek]

On 6.07.2023 13:20, Zbigniew Kempczyński wrote:
> On Thu, Jul 06, 2023 at 10:31:15AM +0200, Karolina Stolarek wrote:
>> On 6.07.2023 08:05, Zbigniew Kempczyński wrote:
>>> There's no real user of this api, lets drop it.
>>>
>>
>> Should we drop REQ_OPEN_AS and/or RESP_OPEN_AS enum values as well?
>>
> 
> Good catch, thanks. Will be in v3.

If you decide to delete them, also remember about the switch statement 
in handle_request(), it will require a cleanup as well.

All the best,
Karolina

> 
> --
> Zbigniew
> 
>> All the best,
>> Karolina
>>
>>> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
>>> ---
>>>    lib/intel_allocator.c | 18 ------------------
>>>    lib/intel_allocator.h |  1 -
>>>    2 files changed, 19 deletions(-)
>>>
>>> diff --git a/lib/intel_allocator.c b/lib/intel_allocator.c
>>> index 8161221dbf..c31576ecef 100644
>>> --- a/lib/intel_allocator.c
>>> +++ b/lib/intel_allocator.c
>>> @@ -1037,24 +1037,6 @@ uint64_t intel_allocator_open_vm(int fd, uint32_t vm, uint8_t allocator_type)
>>>    					    ALLOC_STRATEGY_HIGH_TO_LOW, 0);
>>>    }
>>> -uint64_t intel_allocator_open_vm_as(uint64_t allocator_handle, uint32_t new_vm)
>>> -{
>>> -	struct alloc_req req = { .request_type = REQ_OPEN_AS,
>>> -				 .allocator_handle = allocator_handle,
>>> -				 .open_as.new_vm = new_vm };
>>> -	struct alloc_resp resp;
>>> -
>>> -	/* Get child_tid only once at open() */
>>> -	if (child_tid == -1)
>>> -		child_tid = gettid();
>>> -
>>> -	igt_assert(handle_request(&req, &resp) == 0);
>>> -	igt_assert(resp.open_as.allocator_handle);
>>> -	igt_assert(resp.response_type == RESP_OPEN_AS);
>>> -
>>> -	return resp.open.allocator_handle;
>>> -}
>>> -
>>>    /**
>>>     * intel_allocator_close:
>>>     * @allocator_handle: handle to the allocator that will be closed
>>> diff --git a/lib/intel_allocator.h b/lib/intel_allocator.h
>>> index a6bf573e9d..3ec74f6191 100644
>>> --- a/lib/intel_allocator.h
>>> +++ b/lib/intel_allocator.h
>>> @@ -182,7 +182,6 @@ uint64_t intel_allocator_open_vm_full(int fd, uint32_t vm,
>>>    				      enum allocator_strategy strategy,
>>>    				      uint64_t default_alignment);
>>> -uint64_t intel_allocator_open_vm_as(uint64_t allocator_handle, uint32_t new_vm);
>>>    bool intel_allocator_close(uint64_t allocator_handle);
>>>    void intel_allocator_get_address_range(uint64_t allocator_handle,
>>>    				       uint64_t *startp, uint64_t *endp);