[igt-dev] [PATCH i-g-t] scripts/test_list.py: fix __filter_subtest() logic

Kamil Konieczny kamil.konieczny at linux.intel.com
Mon Jul 10 14:56:27 UTC 2023


Hi Mauro,

On 2023-07-10 at 11:13:47 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab at kernel.org>
> 
> The logic there is searching a value at the wrong place, as
> "test" variable at the callers are a number inside doc.test
> array. Fix it.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>

Acked-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  scripts/test_list.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/test_list.py b/scripts/test_list.py
> index 19ed5e5467f5..4f580fb3de58 100755
> --- a/scripts/test_list.py
> +++ b/scripts/test_list.py
> @@ -569,7 +569,7 @@ class TestList:
>  
>              subtest_array = self.expand_subtest(fname, name, test, subtest_only)
>              for subtest in subtest_array:
> -                if self.__filter_subtest(test, subtest, True):
> +                if self.__filter_subtest(self.doc[test], subtest, True):
>                      continue
>  
>                  summary = subtest["Summary"]
> @@ -851,7 +851,7 @@ class TestList:
>          subtest_array.sort(key = lambda x : x.get('Summary'))
>  
>          for subtest in subtest_array:
> -            if self.__filter_subtest(test, subtest, True):
> +            if self.__filter_subtest(self.doc[test], subtest, True):
>                  continue
>  
>              if sort_field:
> -- 
> 2.40.1
> 


More information about the igt-dev mailing list