[igt-dev] [i-g-t, v4 1/8] tests/amdgpu/amd_freesync_video_mode: Adjust indents and spacing

Alex Hung alex.hung at amd.com
Mon Jul 10 17:13:01 UTC 2023


Reviewed-by: Alex Hung <alex.hung at amd.com>

On 2023-07-10 01:57, Tom Chung wrote:
> Replace spaces with tabs. Adjust indents and spacing and fix some
> other errors report from checkpatch.pl.
> 
> Signed-off-by: Tom Chung <chiahsuan.chung at amd.com>
> ---
>   tests/amdgpu/amd_freesync_video_mode.c | 533 ++++++++++++-------------
>   1 file changed, 263 insertions(+), 270 deletions(-)
> 
> diff --git a/tests/amdgpu/amd_freesync_video_mode.c b/tests/amdgpu/amd_freesync_video_mode.c
> index 62d42a06c..805988c19 100644
> --- a/tests/amdgpu/amd_freesync_video_mode.c
> +++ b/tests/amdgpu/amd_freesync_video_mode.c
> @@ -42,7 +42,7 @@
>    * rate. Finally, the userspace can also derive an appropriate mode for
>    * a particular refresh rate based on the FreeSync Mode and add it to the
>    * connector’s mode list.
> -*/
> + */
>   IGT_TEST_DESCRIPTION("This tests transition between normal and FreeSync-Video"
>   		     "modes and measures the FPS to ensure vblank events are"
>   		     "happening at the expected rate.");
> @@ -66,23 +66,23 @@ typedef struct data {
>   	int		count_modes;
>   
>   	uint32_t	preferred_mode_index;
> -        uint32_t	base_mode_index;
> +	uint32_t	base_mode_index;
>   	uint32_t	hdisplay;
>   	uint32_t	vdisplay;
>   } data_t;
>   
>   struct fsv_sprite {
> -        uint32_t        w;
> +	uint32_t    w;
>   	uint32_t	h;
> -        uint32_t        *data;
> +	uint32_t    *data;
>   };
>   static struct fsv_sprite cicle_sprite;
>   
>   enum {
> -        FSV_PREFERRED_MODE,
> -        FSV_BASE_MODE,
> -        FSV_FREESYNC_VIDEO_MODE,
> -        FSV_NON_FREESYNC_VIDEO_MODE,
> +	FSV_PREFERRED_MODE,
> +	FSV_BASE_MODE,
> +	FSV_FREESYNC_VIDEO_MODE,
> +	FSV_NON_FREESYNC_VIDEO_MODE,
>   };
>   
>   enum {
> @@ -93,10 +93,10 @@ enum {
>   };
>   
>   enum {
> -	SCENE_BASE_MODE_TO_VARIOUS_FSV_MODE ,
> -	SCENE_LOWER_FSV_MODE_TO_HIGHER_FSV_MODE ,
> -	SCENE_NON_FSV_MODE_TO_FSV_MODE ,
> -	SCENE_BASE_MODE_TO_CUSTUM_MODE ,
> +	SCENE_BASE_MODE_TO_VARIOUS_FSV_MODE,
> +	SCENE_LOWER_FSV_MODE_TO_HIGHER_FSV_MODE,
> +	SCENE_NON_FSV_MODE_TO_FSV_MODE,
> +	SCENE_BASE_MODE_TO_CUSTUM_MODE,
>   	SCENE_NON_FSV_MODE_TO_NON_FSV_MODE,
>   
>   	SCENE_COUNT,
> @@ -136,6 +136,7 @@ static uint64_t get_kernel_event_ns(data_t *data, uint32_t event)
>   static uint64_t get_time_ns(void)
>   {
>   	struct timespec ts;
> +
>   	memset(&ts, 0, sizeof(ts));
>   	errno = 0;
>   
> @@ -149,82 +150,76 @@ static uint64_t get_time_ns(void)
>   }
>   
>   static void fbmem_draw_rect(
> -		uint32_t *fbmem,
> -		uint32_t stride,
> -		uint32_t x,
> -		uint32_t y,
> -		uint32_t w,
> -		uint32_t h,
> -		uint32_t color)
> +	uint32_t *fbmem,
> +	uint32_t stride,
> +	uint32_t x,
> +	uint32_t y,
> +	uint32_t w,
> +	uint32_t h,
> +	uint32_t color)
>   {
> -        uint32_t offset = y * stride + x;
> -
> -        for (uint32_t j = 0; j < h; j++) {
> -                for (uint32_t i = 0; i < w; i++) {
> -                        fbmem[offset + i] = color;
> -                }
> -                offset += stride;
> -        }
> +	uint32_t offset = y * stride + x;
> +
> +	for (uint32_t j = 0; j < h; j++) {
> +		for (uint32_t i = 0; i < w; i++)
> +			fbmem[offset + i] = color;
> +		offset += stride;
> +	}
>   }
>   
>   static void fbmem_draw_smpte_pattern(uint32_t *fbmem, int width, int height)
>   {
>   	uint32_t x, y;
> -        uint32_t colors_top[] = {
> -                MK_COLOR(192, 192, 192), /* grey */
> -                MK_COLOR(192, 192, 0),   /* yellow */
> -                MK_COLOR(0, 192, 192),   /* cyan */
> -                MK_COLOR(0, 192, 0),     /* green */
> -                MK_COLOR(192, 0, 192),   /* magenta */
> -                MK_COLOR(192, 0, 0),     /* red */
> -                MK_COLOR(0, 0, 192),     /* blue */
> -        };
> -        uint32_t colors_middle[] = {
> -                MK_COLOR(0, 0, 192),     /* blue */
> -                MK_COLOR(19, 19, 19),    /* black */
> -                MK_COLOR(192, 0, 192),   /* magenta */
> -                MK_COLOR(19, 19, 19),    /* black */
> -                MK_COLOR(0, 192, 192),   /* cyan */
> -                MK_COLOR(19, 19, 19),    /* black */
> -                MK_COLOR(192, 192, 192), /* grey */
> -        };
> -        uint32_t colors_bottom[] = {
> -                MK_COLOR(0, 33, 76),     /* in-phase */
> -                MK_COLOR(255, 255, 255), /* super white */
> -                MK_COLOR(50, 0, 106),    /* quadrature */
> -                MK_COLOR(19, 19, 19),    /* black */
> -                MK_COLOR(9, 9, 9),       /* 3.5% */
> -                MK_COLOR(19, 19, 19),    /* 7.5% */
> -                MK_COLOR(29, 29, 29),    /* 11.5% */
> -                MK_COLOR(19, 19, 19),    /* black */
> -        };
> -
> -        for (y = 0; y < height * 6 / 9; ++y) {
> -                for (x = 0; x < width; ++x)
> -                        fbmem[x] =
> -                                colors_top[x * 7 / width];
> -                fbmem += width;
> -        }
> -
> -        for (; y < height * 7 / 9; ++y) {
> -                for (x = 0; x < width; ++x)
> -                        fbmem[x] =
> -                                colors_middle[x * 7 / width];
> -                fbmem += width;
> -        }
> -
> -        for (; y < height; ++y) {
> -                for (x = 0; x < width * 5 / 7; ++x)
> -                        fbmem[x] =
> -                                colors_bottom[x * 4 / (width * 5 / 7)];
> -                for (; x < width * 6 / 7; ++x)
> -                        fbmem[x] =
> -                                colors_bottom[(x - width * 5 / 7) * 3
> -                                              / (width / 7) + 4];
> -                for (; x < width; ++x)
> -                        fbmem[x] = colors_bottom[7];
> -                fbmem += width;
> -        }
> +	uint32_t colors_top[] = {
> +		MK_COLOR(192, 192, 192), /* grey */
> +		MK_COLOR(192, 192, 0),   /* yellow */
> +		MK_COLOR(0, 192, 192),   /* cyan */
> +		MK_COLOR(0, 192, 0),     /* green */
> +		MK_COLOR(192, 0, 192),   /* magenta */
> +		MK_COLOR(192, 0, 0),     /* red */
> +		MK_COLOR(0, 0, 192),     /* blue */
> +	};
> +	uint32_t colors_middle[] = {
> +		MK_COLOR(0, 0, 192),     /* blue */
> +		MK_COLOR(19, 19, 19),    /* black */
> +		MK_COLOR(192, 0, 192),   /* magenta */
> +		MK_COLOR(19, 19, 19),    /* black */
> +		MK_COLOR(0, 192, 192),   /* cyan */
> +		MK_COLOR(19, 19, 19),    /* black */
> +		MK_COLOR(192, 192, 192), /* grey */
> +	};
> +	uint32_t colors_bottom[] = {
> +		MK_COLOR(0, 33, 76),     /* in-phase */
> +		MK_COLOR(255, 255, 255), /* super white */
> +		MK_COLOR(50, 0, 106),    /* quadrature */
> +		MK_COLOR(19, 19, 19),    /* black */
> +		MK_COLOR(9, 9, 9),       /* 3.5% */
> +		MK_COLOR(19, 19, 19),    /* 7.5% */
> +		MK_COLOR(29, 29, 29),    /* 11.5% */
> +		MK_COLOR(19, 19, 19),    /* black */
> +	};
> +
> +	for (y = 0; y < height * 6 / 9; ++y) {
> +		for (x = 0; x < width; ++x)
> +			fbmem[x] = colors_top[x * 7 / width];
> +		fbmem += width;
> +	}
> +
> +	for (; y < height * 7 / 9; ++y) {
> +		for (x = 0; x < width; ++x)
> +			fbmem[x] = colors_middle[x * 7 / width];
> +		fbmem += width;
> +	}
> +
> +	for (; y < height; ++y) {
> +		for (x = 0; x < width * 5 / 7; ++x)
> +			fbmem[x] = colors_bottom[x * 4 / (width * 5 / 7)];
> +		for (; x < width * 6 / 7; ++x)
> +			fbmem[x] = colors_bottom[(x - width * 5 / 7) * 3 / (width / 7) + 4];
> +		for (; x < width; ++x)
> +			fbmem[x] = colors_bottom[7];
> +		fbmem += width;
> +	}
>   }
>   
>   static void sprite_init(
> @@ -232,13 +227,13 @@ static void sprite_init(
>   		uint32_t w,
>   		uint32_t h)
>   {
> -        igt_assert(sprite);
> +	igt_assert(sprite);
>   
> -        sprite->data = (uint32_t *)malloc(w * h * BYTES_PER_PIXEL);
> -        igt_assert(sprite->data);
> +	sprite->data = (uint32_t *)malloc(w * h * BYTES_PER_PIXEL);
> +	igt_assert(sprite->data);
>   
> -        sprite->w = w;
> -        sprite->h = h;
> +	sprite->w = w;
> +	sprite->h = h;
>   }
>   
>   static void sprite_paste(
> @@ -248,14 +243,14 @@ static void sprite_paste(
>   		uint32_t x,
>   		uint32_t y)
>   {
> -        uint32_t fb_offset = y * fb_stride + x;
> -        uint32_t sprite_offset = 0;
> -
> -        for (int j = 0; j < sprite->h; j++) {
> -                memcpy(fbmem + fb_offset, sprite->data + sprite_offset, sprite->w * 4);
> -                sprite_offset += sprite->w;
> -                fb_offset += fb_stride;
> -        }
> +	uint32_t fb_offset = y * fb_stride + x;
> +	uint32_t sprite_offset = 0;
> +
> +	for (int j = 0; j < sprite->h; j++) {
> +		memcpy(fbmem + fb_offset, sprite->data + sprite_offset, sprite->w * 4);
> +		sprite_offset += sprite->w;
> +		fb_offset += fb_stride;
> +	}
>   }
>   
>   static void sprite_draw_rect(
> @@ -266,16 +261,15 @@ static void sprite_draw_rect(
>   		uint32_t h,
>   		uint32_t color)
>   {
> -        uint32_t offset = y * sprite->w + x;
> -        uint32_t *addr = (uint32_t *)sprite->data;
> -
> -        for (uint32_t j = 0; j < h; j++) {
> -                addr = (uint32_t *)(sprite->data + offset);
> -                for (uint32_t i = 0; i < w; i++) {
> -                        addr[i] = color;
> -                }
> -                offset += sprite->w;
> -        }
> +	uint32_t offset = y * sprite->w + x;
> +	uint32_t *addr = (uint32_t *)sprite->data;
> +
> +	for (uint32_t j = 0; j < h; j++) {
> +		addr = (uint32_t *)(sprite->data + offset);
> +		for (uint32_t i = 0; i < w; i++)
> +			addr[i] = color;
> +		offset += sprite->w;
> +	}
>   }
>   
>   /* drawing horizontal line in the sprite */
> @@ -287,9 +281,9 @@ static void sprite_draw_hline(
>   		uint32_t color)
>   {
>   	uint32_t offset = y1 * sprite->w;
> -        for (int x = x1 ; x < x2; x++) {
> -                sprite->data[offset + x] = color;
> -        }
> +
> +	for (int x = x1 ; x < x2; x++)
> +		sprite->data[offset + x] = color;
>   }
>   
>   /* drawing filled circle with Bresenham's algorithm */
> @@ -300,155 +294,157 @@ static void sprite_draw_circle(
>   		uint32_t radius,
>   		uint32_t color)
>   {
> -        int offsetx = 0, offsety = radius, d = radius -1;
> -
> -        while (offsety >= offsetx) {
> -                sprite_draw_hline(sprite, x - offsety, y + offsetx,
> -                                x + offsety, color);
> -                sprite_draw_hline(sprite, x - offsetx, y + offsety,
> -                                x + offsetx, color);
> -                sprite_draw_hline(sprite, x - offsetx, y - offsety,
> -                                x + offsetx, color);
> -                sprite_draw_hline(sprite, x - offsety, y - offsetx,
> -                                x + offsety, color);
> -
> -                if (d >= 2 * offsetx) {
> -                        d -= 2 * offsetx + 1;
> -                        offsetx += 1;
> -                } else if (d < 2 * (radius - offsety)) {
> -                        d += 2 * offsety - 1;
> -                        offsety -= 1;
> -                } else {
> -                        d += 2 * (offsety - offsetx - 1);
> -                        offsety -= 1;
> -                        offsetx += 1;
> -                }
> -        }
> +	int offsetx = 0, offsety = radius, d = radius - 1;
> +
> +	while (offsety >= offsetx) {
> +		sprite_draw_hline(sprite, x - offsety, y + offsetx,
> +				  x + offsety, color);
> +		sprite_draw_hline(sprite, x - offsetx, y + offsety,
> +				  x + offsetx, color);
> +		sprite_draw_hline(sprite, x - offsetx, y - offsety,
> +				  x + offsetx, color);
> +		sprite_draw_hline(sprite, x - offsety, y - offsetx,
> +				  x + offsety, color);
> +
> +		if (d >= 2 * offsetx) {
> +			d -= 2 * offsetx + 1;
> +			offsetx += 1;
> +		} else if (d < 2 * (radius - offsety)) {
> +			d += 2 * offsety - 1;
> +			offsety -= 1;
> +		} else {
> +			d += 2 * (offsety - offsetx - 1);
> +			offsety -= 1;
> +			offsetx += 1;
> +		}
> +	}
>   }
>   
>   static void sprite_anim_init(void)
>   {
> -        memset(&cicle_sprite, 0, sizeof(cicle_sprite));
> -        sprite_init(&cicle_sprite, 100, 100);
> +	memset(&cicle_sprite, 0, sizeof(cicle_sprite));
> +	sprite_init(&cicle_sprite, 100, 100);
>   
> -        sprite_draw_rect(&cicle_sprite, 0, 0, 100, 100, MK_COLOR(128, 128, 128));
> +	sprite_draw_rect(&cicle_sprite, 0, 0, 100, 100, MK_COLOR(128, 128, 128));
>   	/* draw filled circle with center (50, 50), radius 50. */
> -        sprite_draw_circle(&cicle_sprite, 50, 50, 50, MK_COLOR(0, 0, 255));
> +	sprite_draw_circle(&cicle_sprite, 50, 50, 50, MK_COLOR(0, 0, 255));
>   }
>   
>   static void sprite_anim(data_t *data, uint32_t *addr)
>   {
> -        struct timeval tv1, tv2, tv_delta;
> -        uint64_t frame_ns = get_time_ns();
> -        double now = frame_ns / (double)NSECS_PER_SEC;
> +	struct timeval tv1, tv2, tv_delta;
> +	uint64_t frame_ns = get_time_ns();
> +	double now = frame_ns / (double)NSECS_PER_SEC;
>   
> -        gettimeofday(&tv1, NULL);
> +	gettimeofday(&tv1, NULL);
>   
> -        fbmem_draw_rect(addr, data->hdisplay, 0, 0,
> +	fbmem_draw_rect(addr, data->hdisplay, 0, 0,
>   			data->hdisplay, data->vdisplay, MK_COLOR(128, 128, 128));
>   	/* red rectangle for checking tearing effect*/
> -        if (data->front) {
> -                fbmem_draw_rect(addr, data->hdisplay, 0, 0,
> +	if (data->front) {
> +		fbmem_draw_rect(addr, data->hdisplay, 0, 0,
>   			30, data->vdisplay, MK_COLOR(191, 0, 0));
> -        }
> +	}
>   
>   	/* draw 16 filled circles */
> -        for (int i = 0; i < 16; ++i) {
> -                double tv = now + i * 0.25;
> -                float x, y;
> -                x = data->hdisplay - 10.0f - 118.0f * i - 100.0f;
> -                y = data->vdisplay * 0.5f + cos(tv) * data->vdisplay * 0.35;
> -                sprite_paste(addr, data->hdisplay, &cicle_sprite, (uint32_t)x, (uint32_t)y);
> -        }
> -
> -        gettimeofday(&tv2, NULL);
> -        timersub(&tv2, &tv1, &tv_delta);
> -
> -        igt_debug("time of drawing: %ld ms\n", tv_delta.tv_usec / 1000);
> +	for (int i = 0; i < 16; ++i) {
> +		double tv = now + i * 0.25;
> +		float x, y;
> +
> +		x = data->hdisplay - 10.0f - 118.0f * i - 100.0f;
> +		y = data->vdisplay * 0.5f + cos(tv) * data->vdisplay * 0.35;
> +		sprite_paste(addr, data->hdisplay, &cicle_sprite, (uint32_t)x, (uint32_t)y);
> +	}
> +
> +	gettimeofday(&tv2, NULL);
> +	timersub(&tv2, &tv1, &tv_delta);
> +
> +	igt_debug("time of drawing: %ld ms\n", tv_delta.tv_usec / 1000);
>   }
>   
>   /*----------------------------------------------------------------------------*/
>   
>   /* The freesync video modes is derived from the base mode(the mode with the
> -   highest clock rate, and has the same resolution with preferred mode) by
> -   amdgpu driver. They have the same clock rate with base mode, and the
> -   type of mode has been set as DRM_MODE_TYPE_DRIVER"
> -*/
> + * highest clock rate, and has the same resolution with preferred mode) by
> + * amdgpu driver. They have the same clock rate with base mode, and the
> + * type of mode has been set as DRM_MODE_TYPE_DRIVER"
> + */
>   static bool is_freesync_video_mode(data_t *data, drmModeModeInfo *mode)
>   {
> -        drmModeModeInfo *base_mode = &data->modes[data->base_mode_index];
> -        uint32_t bm_clock = base_mode->clock;
> -
> -        if (    mode->hdisplay == data->hdisplay &&
> -                mode->vdisplay == data->vdisplay &&
> -                mode->clock == bm_clock &&
> -		mode->type & DRM_MODE_TYPE_DRIVER) {
> -                return true;
> -        }
> +	drmModeModeInfo *base_mode = &data->modes[data->base_mode_index];
> +	uint32_t bm_clock = base_mode->clock;
> +
> +	if (mode->hdisplay == data->hdisplay &&
> +	    mode->vdisplay == data->vdisplay &&
> +	    mode->clock == bm_clock &&
> +	    mode->type & DRM_MODE_TYPE_DRIVER) {
> +		return true;
> +	}
>   
> -        return false;
> +	return false;
>   }
>   
> -static drmModeModeInfo* select_mode(
> -        data_t *data,
> -        uint32_t mode_type,
> -        int refresh_rate)
> +static drmModeModeInfo *select_mode(
> +	data_t *data,
> +	uint32_t mode_type,
> +	int refresh_rate)
>   {
>   	int i;
> -        int index;
> -        drmModeModeInfo *mode = NULL;
> +	int index;
> +	drmModeModeInfo *mode = NULL;
> +
>   	igt_debug("select_mode: type=%d, refresh_rate=%d\n", mode_type, refresh_rate);
>   
> -        switch (mode_type) {
> -        case FSV_BASE_MODE:
> -                index = data->base_mode_index;
> -                mode = &data->modes[index];
> -                break;
> -
> -        case FSV_PREFERRED_MODE:
> -                index = data->preferred_mode_index;
> -                mode = &data->modes[index];
> -                break;
> -
> -        case FSV_FREESYNC_VIDEO_MODE:
> -                for (i = 0; i < data->count_modes; i++) {
> -                        mode = &data->modes[i];
> -                        if (    mode->vrefresh == refresh_rate &&
> -                                is_freesync_video_mode(data, mode)) {
> -                                break;
> -                        }
> -                }
> +	switch (mode_type) {
> +	case FSV_BASE_MODE:
> +		index = data->base_mode_index;
> +		mode = &data->modes[index];
> +		break;
> +
> +	case FSV_PREFERRED_MODE:
> +		index = data->preferred_mode_index;
> +		mode = &data->modes[index];
> +		break;
> +
> +	case FSV_FREESYNC_VIDEO_MODE:
> +		for (i = 0; i < data->count_modes; i++) {
> +			mode = &data->modes[i];
> +			if (mode->vrefresh == refresh_rate &&
> +			    is_freesync_video_mode(data, mode)) {
> +				break;
> +			}
> +		}
>   		if (i == data->count_modes)
>   			mode = NULL;
> -                break;
> -
> -        case FSV_NON_FREESYNC_VIDEO_MODE:
> -                for (i = 0; i < data->count_modes; i++) {
> -                        mode = &data->modes[i];
> -                        if (    mode->vrefresh == refresh_rate &&
> -                                !is_freesync_video_mode(data, mode)) {
> -                                break;
> -                        }
> -                }
> +		break;
> +
> +	case FSV_NON_FREESYNC_VIDEO_MODE:
> +		for (i = 0; i < data->count_modes; i++) {
> +			mode = &data->modes[i];
> +			if (mode->vrefresh == refresh_rate &&
> +			    !is_freesync_video_mode(data, mode)) {
> +				break;
> +			}
> +		}
>   		if (i == data->count_modes)
>   			mode = NULL;
> -                break;
> +		break;
>   
> -        default:
> -                igt_assert("Cannot find mode with specified rate and type.");
> -                break;
> -        }
> +	default:
> +		igt_assert("Cannot find mode with specified rate and type.");
> +		break;
> +	}
>   
>   	if (mode) {
>   		igt_info("selected mode:\n");
>   		kmstest_dump_mode(mode);
>   	}
>   
> -        return mode;
> +	return mode;
>   }
>   
>   static int prepare_custom_mode(
> -        data_t *data,
> +	data_t *data,
>   	drmModeModeInfo *custom_mode,
>   	uint32_t refresh_rate)
>   {
> @@ -477,10 +473,8 @@ static int prepare_custom_mode(
>   	den = refresh_rate * 1000 * (unsigned long long)base_mode->htotal;
>   	target_vtotal = num / den;
>   	target_vtotal_diff = target_vtotal - base_mode->vtotal;
> -	igt_debug("num=%lu, den=%lu, " \
> -                  "target_vtotal=%lu, target_vtotal_diff=%lu, base_mode->vtotal=%d\n",
> -		  num, den, target_vtotal, target_vtotal_diff, base_mode->vtotal
> -		);
> +	igt_debug("num=%lu, den=%lu, target_vtotal=%lu, target_vtotal_diff=%lu, base_mode->vtotal=%d\n",
> +		num, den, target_vtotal, target_vtotal_diff, base_mode->vtotal);
>   
>   	/* Check for illegal modes */
>   	if (base_mode->vsync_start + target_vtotal_diff < base_mode->vdisplay ||
> @@ -680,7 +674,8 @@ flip_and_measure(
>   	return total_flip ? ((total_pass * 100) / total_flip) : 0;
>   }
>   
> -static void init_data(data_t *data, igt_output_t *output) {
> +static void init_data(data_t *data, igt_output_t *output)
> +{
>   	int i;
>   	uint32_t pm_hdisplay, pm_vdisplay, max_clk = 0;
>   	drmModeModeInfo *preferred_mode;
> @@ -699,36 +694,38 @@ static void init_data(data_t *data, igt_output_t *output) {
>   	}
>   
>   	/* searching the preferred mode */
> -        for (i = 0; i < connector->count_modes; i++) {
> -                drmModeModeInfo *mode = &connector->modes[i];
> +	for (i = 0; i < connector->count_modes; i++) {
> +		drmModeModeInfo *mode = &connector->modes[i];
>   
> -                if (mode->type & DRM_MODE_TYPE_PREFERRED) {
> -                        data->preferred_mode_index = i;
> +		if (mode->type & DRM_MODE_TYPE_PREFERRED) {
> +			data->preferred_mode_index = i;
>   			data->hdisplay = mode->hdisplay;
>   			data->vdisplay = mode->vdisplay;
>   			pm_hdisplay = preferred_mode->hdisplay;
>   			pm_vdisplay = preferred_mode->vdisplay;
>   			break;
> -                }
> -        }
> -
> -        /* searching the base mode; */
> -        for (i = 0; i < connector->count_modes; i++) {
> -                drmModeModeInfo *mode = &connector->modes[i];
> -                if (mode->hdisplay == pm_hdisplay && mode->vdisplay == pm_vdisplay) {
> -                        if (mode->clock > max_clk) {
> -                                max_clk = mode->clock;
> -                                data->base_mode_index = i;
> -                        }
> -                }
> -        }
> -        igt_info("preferred=%d, base=%d\n", data->preferred_mode_index, data->base_mode_index);
> -
> -        for (i = 0; i < connector->count_modes; i++) {
> -                drmModeModeInfo *mode = &connector->modes[i];
> -                if (is_freesync_video_mode(data, mode))
> -                        igt_debug("mode[%d] is freesync video mode.\n", i);
> -        }
> +		}
> +	}
> +
> +	/* searching the base mode; */
> +	for (i = 0; i < connector->count_modes; i++) {
> +		drmModeModeInfo *mode = &connector->modes[i];
> +
> +		if (mode->hdisplay == pm_hdisplay && mode->vdisplay == pm_vdisplay) {
> +			if (mode->clock > max_clk) {
> +				max_clk = mode->clock;
> +				data->base_mode_index = i;
> +			}
> +		}
> +	}
> +	igt_info("preferred=%d, base=%d\n", data->preferred_mode_index, data->base_mode_index);
> +
> +	for (i = 0; i < connector->count_modes; i++) {
> +		drmModeModeInfo *mode = &connector->modes[i];
> +
> +		if (is_freesync_video_mode(data, mode))
> +			igt_debug("mode[%d] is freesync video mode.\n", i);
> +	}
>   
>   	data->range = get_vrr_range(data, output);
>   }
> @@ -758,20 +755,20 @@ mode_transition(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t sce
>   	sprite_anim_init();
>   
>   	igt_info("stage-1:\n");
> -	switch(scene) {
> -        case SCENE_BASE_MODE_TO_VARIOUS_FSV_MODE:
> +	switch (scene) {
> +	case SCENE_BASE_MODE_TO_VARIOUS_FSV_MODE:
>   		mode_start = select_mode(data, FSV_BASE_MODE, 0);
> -                mode_playback  = select_mode(data, FSV_FREESYNC_VIDEO_MODE, 60);
> +		mode_playback  = select_mode(data, FSV_FREESYNC_VIDEO_MODE, 60);
>   		break;
> -        case SCENE_LOWER_FSV_MODE_TO_HIGHER_FSV_MODE:
> +	case SCENE_LOWER_FSV_MODE_TO_HIGHER_FSV_MODE:
>   		mode_start = select_mode(data, FSV_FREESYNC_VIDEO_MODE, 60);
> -                mode_playback = select_mode(data, FSV_FREESYNC_VIDEO_MODE, 120);
> +		mode_playback = select_mode(data, FSV_FREESYNC_VIDEO_MODE, 120);
>   		break;
> -        case SCENE_NON_FSV_MODE_TO_FSV_MODE:
> +	case SCENE_NON_FSV_MODE_TO_FSV_MODE:
>   		mode_start = select_mode(data, FSV_NON_FREESYNC_VIDEO_MODE, 60);
> -                mode_playback = select_mode(data, FSV_FREESYNC_VIDEO_MODE, 60);
> +		mode_playback = select_mode(data, FSV_FREESYNC_VIDEO_MODE, 60);
>   		break;
> -        case SCENE_BASE_MODE_TO_CUSTUM_MODE:
> +	case SCENE_BASE_MODE_TO_CUSTUM_MODE:
>   		mode_start = select_mode(data, FSV_BASE_MODE, 0);
>   		prepare_custom_mode(data, &mode_custom, 72);
>   		mode_playback = &mode_custom;
> @@ -787,13 +784,13 @@ mode_transition(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t sce
>   	igt_assert_f(mode_start && mode_playback,
>   			"Failure on selecting mode with given type and refresh rate.\n");
>   	prepare_test(data, output, pipe, mode_start);
> -	interval = nsec_per_frame(mode_start->vrefresh) ;
> +	interval = nsec_per_frame(mode_start->vrefresh);
>   	set_vrr_on_pipe(data, pipe, 1);
>   	result = flip_and_measure(data, output, pipe, interval, TEST_DURATION_NS, ANIM_TYPE_SMPTE);
>   
>   	igt_info("stage-2: simple animation as video playback\n");
>   	prepare_test(data, output, pipe, mode_playback);
> -	interval = nsec_per_frame(mode_playback->vrefresh) ;
> +	interval = nsec_per_frame(mode_playback->vrefresh);
>   	result = flip_and_measure(data, output, pipe, interval, TEST_DURATION_NS, ANIM_TYPE_CIRCLE_WAVE);
>   	igt_assert_f(result > 90, "Target refresh rate not meet(result=%d%%\n", result);
>   
> @@ -824,9 +821,9 @@ run_test(data_t *data, uint32_t scene)
>   		igt_skip("No vrr capable outputs found.\n");
>   }
>   
> -igt_main
> -{
> +igt_main {
>   	data_t data = {};
> +
>   	memset(&data, 0, sizeof(data));
>   
>   	igt_fixture {
> @@ -841,30 +838,26 @@ igt_main
>   	}
>   
>   	/* Expectation: Modeset happens instantaneously without blanking */
> -        igt_describe("Test switch from base freesync mode to " \
> -                     "various freesync video modes");
> -        igt_subtest("freesync-base-to-various")
> -		run_test(&data, SCENE_BASE_MODE_TO_VARIOUS_FSV_MODE);
> +	igt_describe("Test switch from base freesync mode to various freesync video modes");
> +	igt_subtest("freesync-base-to-various")
> +	run_test(&data, SCENE_BASE_MODE_TO_VARIOUS_FSV_MODE);
>   
>   	/* Expectation: Modeset happens instantaneously without blanking */
> -        igt_describe("Test switching from lower refresh freesync mode to " \
> -                     "another freesync mode with higher refresh rate");
> -        igt_subtest("freesync-lower-to-higher")
> -		run_test(&data, SCENE_LOWER_FSV_MODE_TO_HIGHER_FSV_MODE);
> +	igt_describe("Test switching from lower refresh freesync mode to another freesync mode with higher refresh rate");
> +	igt_subtest("freesync-lower-to-higher")
> +	run_test(&data, SCENE_LOWER_FSV_MODE_TO_HIGHER_FSV_MODE);
>   
>   	/* Expectation: Full modeset is triggered. */
> -        igt_describe("Test switching from non preferred video mode to " \
> -                     "one of freesync video mode");
> -        igt_subtest("freesync-non-preferred-to-freesync")
> -		run_test(&data, SCENE_NON_FSV_MODE_TO_FSV_MODE);
> +	igt_describe("Test switching from non preferred video mode to one of freesync video mode");
> +	igt_subtest("freesync-non-preferred-to-freesync")
> +	run_test(&data, SCENE_NON_FSV_MODE_TO_FSV_MODE);
>   
>   	/* Expectation: Modeset happens instantaneously without blanking */
> -        igt_describe("Add custom mode through xrandr based on " \
> -                     "base freesync mode and apply the new mode");
> -        igt_subtest("freesync-custom-mode")
> -		run_test(&data, SCENE_BASE_MODE_TO_CUSTUM_MODE);
> +	igt_describe("Add custom mode through xrandr based on base freesync mode and apply the new mode");
> +	igt_subtest("freesync-custom-mode")
> +	run_test(&data, SCENE_BASE_MODE_TO_CUSTUM_MODE);
>   
> -        igt_info("end of test\n");
> +	igt_info("end of test\n");
>   
>   	igt_fixture {
>   		igt_display_fini(&data.display);


More information about the igt-dev mailing list