[igt-dev] [i-g-t, v4 7/8] tests/amdgpu/amd_freesync_video_mode: Fix wrong resolution setting for some panel
Alex Hung
alex.hung at amd.com
Mon Jul 10 17:19:37 UTC 2023
Reviewed-by: Alex Hung <alex.hung at amd.com>
On 2023-07-10 01:57, Tom Chung wrote:
> [Why]
> Some eDP panel VRR range only has 48-60Hz and it will cause some of the test failed.
>
> [How]
> Use the VRR range fps to select the mode for test.
>
> Signed-off-by: Tom Chung <chiahsuan.chung at amd.com>
> ---
> tests/amdgpu/amd_freesync_video_mode.c | 25 ++++++++++++++++---------
> 1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/tests/amdgpu/amd_freesync_video_mode.c b/tests/amdgpu/amd_freesync_video_mode.c
> index 60b1da589..7716598dc 100644
> --- a/tests/amdgpu/amd_freesync_video_mode.c
> +++ b/tests/amdgpu/amd_freesync_video_mode.c
> @@ -421,11 +421,18 @@ static drmModeModeInfo *select_mode(
> case FSV_NON_FREESYNC_VIDEO_MODE:
> for (i = 0; i < data->count_modes; i++) {
> mode = &data->modes[i];
> - if (mode->hdisplay == data->hdisplay &&
> - mode->vdisplay == data->vdisplay &&
> - mode->vrefresh == refresh_rate &&
> - !is_freesync_video_mode(data, mode))
> - break;
> + if (refresh_rate > 0) {
> + if (mode->hdisplay == data->hdisplay &&
> + mode->vdisplay == data->vdisplay &&
> + mode->vrefresh == refresh_rate &&
> + !is_freesync_video_mode(data, mode))
> + break;
> + } else {
> + if (mode->hdisplay == data->hdisplay &&
> + mode->vdisplay == data->vdisplay &&
> + !is_freesync_video_mode(data, mode))
> + break;
> + }
> }
> if (i >= data->count_modes)
> mode = NULL;
> @@ -780,16 +787,16 @@ mode_transition(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t sce
> mode_playback = select_mode(data, FSV_FREESYNC_VIDEO_MODE, 60);
> break;
> case SCENE_LOWER_FSV_MODE_TO_HIGHER_FSV_MODE:
> - mode_start = select_mode(data, FSV_FREESYNC_VIDEO_MODE, 60);
> - mode_playback = select_mode(data, FSV_FREESYNC_VIDEO_MODE, 120);
> + mode_start = select_mode(data, FSV_FREESYNC_VIDEO_MODE, data->vrr_range.min);
> + mode_playback = select_mode(data, FSV_FREESYNC_VIDEO_MODE, data->vrr_range.max);
> break;
> case SCENE_NON_FSV_MODE_TO_FSV_MODE:
> - mode_start = select_mode(data, FSV_NON_FREESYNC_VIDEO_MODE, 60);
> + mode_start = select_mode(data, FSV_NON_FREESYNC_VIDEO_MODE, 0);
> mode_playback = select_mode(data, FSV_FREESYNC_VIDEO_MODE, 60);
> break;
> case SCENE_BASE_MODE_TO_CUSTUM_MODE:
> mode_start = select_mode(data, FSV_BASE_MODE, 0);
> - ret = prepare_custom_mode(data, &mode_custom, 72);
> + ret = prepare_custom_mode(data, &mode_custom, data->vrr_range.min);
> igt_assert_eq(ret, 0);
> mode_playback = &mode_custom;
> break;
More information about the igt-dev
mailing list