[igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Inform about unsupported bpp

Kamil Konieczny kamil.konieczny at linux.intel.com
Tue Jul 11 16:37:28 UTC 2023


Hi Karolina,

On 2023-07-11 at 13:45:18 +0200, Karolina Stolarek wrote:
> Log a message when we request an invalid pixel depth in
> intel_bb_emit_blt_copy().
> 
> Signed-off-by: Karolina Stolarek <karolina.stolarek at intel.com>
> ---
>  lib/intel_batchbuffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> index 0e92c6f70..0408d62ba 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -2742,7 +2742,7 @@ void intel_bb_emit_blt_copy(struct intel_bb *ibb,
>  				     XY_SRC_COPY_BLT_WRITE_RGB);
>  			break;
>  		default:
> -			igt_fail(IGT_EXIT_FAILURE);
> +			igt_assert_f(0, "Unsupported pixel depth\n");

LGTM,

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

>  		}
>  	} else {
>  		br13_bits = fast_copy_dword1(ibb->fd, src->tiling, dst->tiling, bpp);
> -- 
> 2.25.1
> 


More information about the igt-dev mailing list