[igt-dev] [PATCH i-g-t v3 17/17] tests/gem_ccs: Avoid writing png twice

Karolina Stolarek karolina.stolarek at intel.com
Wed Jul 12 09:24:49 UTC 2023


On 11.07.2023 13:20, Zbigniew Kempczyński wrote:
> As Karolina noticed we write source png twice what's just takes
> time as source surface is not touched. Drop one png write.

It was outside of the scope, but you did it! Thanks for writing this patch:

Reviewed-by: Karolina Stolarek <karolina.stolarek at intel.com>

> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Karolina Stolarek <karolina.stolarek at intel.com>
> ---
>   tests/i915/gem_ccs.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tests/i915/gem_ccs.c b/tests/i915/gem_ccs.c
> index d9d785ed9b..a1302e0a4d 100644
> --- a/tests/i915/gem_ccs.c
> +++ b/tests/i915/gem_ccs.c
> @@ -421,7 +421,6 @@ static void block_copy(int i915,
>   	if (mid->compression)
>   		igt_assert(memcmp(src->ptr, mid->ptr, src->size) != 0);
>   
> -	WRITE_PNG(i915, run_id, "src", &blt.src, width, height);
>   	WRITE_PNG(i915, run_id, "mid", &blt.dst, width, height);
>   
>   	if (config->surfcopy && pext) {


More information about the igt-dev mailing list