[igt-dev] [PATCH i-g-t v2 09/13] scripts/igt_doc.py: use field names when create a TestList instance

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed Jul 12 18:50:53 UTC 2023


Hi Mauro,
On 2023-07-12 at 15:58:50 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab at kernel.org>
> 
> Makes the caller more generic by explicitly passing the field
> name when calling TestList. This allows updating the class and
> eventually re-ordering fields without the need of changes on
> igt_doc.py.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  scripts/igt_doc.py | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/igt_doc.py b/scripts/igt_doc.py
> index c02029e03a31..4f4c5c755c44 100755
> --- a/scripts/igt_doc.py
> +++ b/scripts/igt_doc.py
> @@ -48,8 +48,10 @@ parser.add_argument('--files', nargs='+',
>  
>  parse_args = parser.parse_args()
>  
> -tests = TestList(parse_args.config, parse_args.include_plan, parse_args.files,
> -                 parse_args.built_testlist)
> +tests = TestList(config_fname = parse_args.config,
> +                 include_plan = parse_args.include_plan,
> +                 file_list = parse_args.files,
> +                 built_testlist = parse_args.built_testlist)
>  
>  if parse_args.filter_field:
>      for filter_expr in parse_args.filter_field:
> -- 
> 2.40.1
> 


More information about the igt-dev mailing list