[igt-dev] [PATCH i-g-t v2 11/13] scripts/test_list.py: filename arguments for print_ methods are optional

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed Jul 12 18:55:21 UTC 2023


Hi Mauro,

On 2023-07-12 at 15:58:52 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab at kernel.org>
> 
> Add a default to those, as the code doesn't need any arguments.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  scripts/test_list.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/test_list.py b/scripts/test_list.py
> index 6e3cab206e82..1551bc92c010 100644
> --- a/scripts/test_list.py
> +++ b/scripts/test_list.py
> @@ -616,7 +616,7 @@ class TestList:
>      # Output methods
>      #
>  
> -    def print_rest_flat(self, filename):
> +    def print_rest_flat(self, filename = None):
>  
>          """Print tests and subtests ordered by tests"""
>  
> @@ -728,7 +728,7 @@ class TestList:
>                      sheet[row].append('')
>          return sheet
>  
> -    def print_nested_rest(self, filename):
> +    def print_nested_rest(self, filename = None):
>  
>          """Print tests and subtests ordered by tests"""
>  
> -- 
> 2.40.1
> 


More information about the igt-dev mailing list