[igt-dev] [PATCH i-g-t v3] tests/xe: Verify actual frequency on the basis of GT state

Nilawar, Badal badal.nilawar at intel.com
Wed Jul 19 05:35:35 UTC 2023



On 18-07-2023 23:58, Dixit, Ashutosh wrote:
> On Tue, 18 Jul 2023 11:24:55 -0700, Dixit, Ashutosh wrote:
>>
>> Sorry I missed this yesterday. Basically why do we have the
>> igt_wait(xe_is_gt_in_c6()) above at the top when we are waking up the gt
>> when reading cur freq later?
>>
>> Maybe instead of this usleep, we can this do here:
>>
>> 		igt_assert(igt_wait(xe_is_gt_in_c6(fd, gt_id), 1000, 1));
> 
> Actually, maybe:
> 
> 		igt_assert(igt_wait(xe_is_gt_in_c6(fd, gt_id), 1000, 10))Sure I will make this change.
> 
>>
>> And get rid of the igt_require(igt_wait()) at the top?
This is added to skip test if RC6 disabled or not working. As discussed 
offline I will move this to igt_main.

Regards,
Badal
>>
>> Thanks.
>> --
>> Ashutosh


More information about the igt-dev mailing list