[igt-dev] [PATCH i-g-t] tests/kms_hdmi_inject: As audio driver is blacklisted so loading the module before the test run

[Garg, Nemesa]

Hi Kamil,

Thanks for your comments. I have floated a new patch for same changes.

Please ignore this patch.

Thanks and Regards,
Nemesa

> -----Original Message-----
> From: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Sent: Tuesday, July 25, 2023 9:35 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Garg, Nemesa <nemesa.garg at intel.com>; Garg at freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_hdmi_inject: As audio driver is
> blacklisted so loading the module before the test run
> 
> Hi Nemesa,
> 
> please make commit message short, this one:
> 
> As audio driver is blacklisted so loading the module before the test run
> 
> is better for description, so maybe something like:
> 
> tests/kms_hdmi_inject: load audio driver before tests
> 
> On 2023-07-20 at 20:32:39 +0530, Garg, Nemesa wrote:
> 
> Write here description why we need it.
> 
> > Signed-off-by: Garg, Nemesa <nemesa.garg at intel.com>
> ---------------- ^ --- ^
> This should be as in your e-mail address:
> 
> Signed-off-by: Nemesa Garg <nemesa.garg at intel.com>
> 
> > ---
> >  tests/kms_hdmi_inject.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c index
> > 9aa5c59fc..1b99e190e 100644
> > --- a/tests/kms_hdmi_inject.c
> > +++ b/tests/kms_hdmi_inject.c
> > @@ -30,6 +30,7 @@
> >  #include "igt_edid.h"
> >  #include "igt_eld.h"
> >  #include "xe/xe_query.h"
> > +#include "igt_kmod.h"
> >
> >  #define HDISPLAY_4K	3840
> >  #define VDISPLAY_4K	2160
> > @@ -208,6 +209,9 @@ igt_main
> >  		kmstest_unset_all_crtcs(drm_fd, res);
> >  	}
> >
> > +	if (!igt_kmod_is_loaded("snd_hda_intel"))
> > +                igt_kmod_load("snd_hda_intel", NULL);
> > +
> 
> Place this in fixture, good place would be in if block which checks for intel
> driver.
> 
> Regards,
> Kamil
> 
> >  	igt_describe("Make sure that 4K modes exposed by DRM match the "
> >                       "forced EDID and modesetting using it succeed.");
> >  	igt_subtest("inject-4k")
> > --
> > 2.25.1
> >