[igt-dev] [PATCH 3/3] kms_cursor_legacy: modeset-atomic-cursor-hotspot

[Javier Martinez Canillas]

Albert Esteve <aesteve at redhat.com> writes:

> On Tue, Jul 25, 2023 at 4:26 PM Javier Martinez Canillas <javierm at redhat.com>
> wrote:
>

[...]

>> Also, there's
>> https://docs.kernel.org/gpu/drm-uapi.html#c.DRM_CAP_CURSOR_WIDTH
>> and DRM_CAP_CURSOR_HEIGHT to query the hardware cursor size. Maybe you
>> should
>> use that instead of assume a 64x64 cursor size ?
>>
>
> In many other tests in the same file the size of the cursor is hardcoded to
> 64, same as here.
> So I kept it consistent.
> Could be a nice refactor, but I guess it is outside the scope of this patch.
>

Ah, didn't look at the rest of the file but yes, agreed that is better to
keep it consistent and in any case the whole file could be cleaned up in
a separate patch.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat