[igt-dev] [PATCH i-g-t] tests/kms_flip: Restrict multi-display hang tests execution

Kamil Konieczny kamil.konieczny at linux.intel.com
Thu Jul 27 14:05:35 UTC 2023


Hi Jeevan,

On 2023-07-27 at 18:25:35 +0530, Jeevan B wrote:
> Restrict the hang tests execution to the first and last pipe
> combinations to avoid timeouts on CI.
> 
> v2: Update the subject and combine the if condition.
> 
> Signed-off-by: Jeevan B <jeevan.b at intel.com>
> ---
>  tests/kms_flip.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index ef2234f74..739939ce3 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1729,9 +1729,13 @@ static void run_pair(int duration, int flags)
>  					crtc_idxs[0] = n;
>  					crtc_idxs[1] = m;
>  
> -					/* Limit the execution to PIPE_A combination for hang tests */
> -					if ((flags & TEST_HANG) && !all_pipes &&
> -					    (n != 0 && n != resources->count_crtcs))
> +					/*
> +					 * Limit the execution to 2 CRTCs
> +					 * (first and last combination) for hang tests
> +					 */
> +					if (((flags & TEST_HANG) && !all_pipes) &&
------------------------------------------- ^ ------------------------------- ^
These braces are not needed. With that fixed

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> +					    ((n != 0 && n != resources->count_crtcs) ||
> +					    m != resources->count_crtcs - 1))
>  						continue;
>  
>  					run_test_on_crtc_set(&o, crtc_idxs,
> -- 
> 2.41.0
> 


More information about the igt-dev mailing list