[igt-dev] [PATCH i-g-t] gem_exec_balancer: move no-GuC requirement to test functions

[Kumar, Janga Rahul]

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of
> Andrzej Hajda
> Sent: 01 June 2023 15:33
> To: igt-dev at lists.freedesktop.org
> Cc: Das, Nirmoy <nirmoy.das at intel.com>
> Subject: [igt-dev] [PATCH i-g-t] gem_exec_balancer: move no-GuC
> requirement to test functions
> 
> Requirements put into igt_subtest_group/igt_fixture are checked for all
> tests in the file.
This comment is misleading, it is not checked for all the tests in the file. igt_fixture inside of subtest_group will get executed even when you run a test outside of it. Suggest you to change it.
 
Even if they do not influence test execution they print
> misleading infos.
> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda at intel.com>

LGTM
Acked-by : Janga Rahul Kumar <janga.rahul.kumar at intel.com>
> ---
>  tests/i915/gem_exec_balancer.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_exec_balancer.c
> b/tests/i915/gem_exec_balancer.c index 004ba9a14fe..9190fc2383f 100644
> --- a/tests/i915/gem_exec_balancer.c
> +++ b/tests/i915/gem_exec_balancer.c
> @@ -1525,6 +1525,7 @@ bonded_runner(int i915,
>  	 * submission across multiple engines.
>  	 */
>  	igt_require(gem_scheduler_has_preemption(i915));
> +	igt_require(!gem_using_guc_submission(i915));
> 
>  	cycles = mmap(0, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -
> 1, 0);
> 
> @@ -1996,6 +1997,7 @@ static void sliced(int i915)
> 
>  	igt_require(gem_scheduler_has_preemption(i915));
>  	igt_require(gem_scheduler_has_semaphores(i915));
> +	igt_require(!gem_using_guc_submission(i915));
> 
>  	for (int class = 0; class < 32; class++) {
>  		struct i915_engine_class_instance *ci; @@ -3605,7 +3607,6
> @@ igt_main
> 
>  	igt_subtest_group {
>  		igt_fixture {
> -			igt_require(!gem_using_guc_submission(i915));
>  			intel_allocator_multiprocess_start();
>  		}
> 
> --
> 2.34.1