[igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: switch blitcopy to use lib/i915/i915_blt functions

[Zbigniew Kempczyński]

On Wed, May 31, 2023 at 06:50:39PM +0300, Juha-Pekka Heikkila wrote:

<cut>

> > > +		for_each_ctx_engine(src_fb->fd, ictx, e) {
> > > +			if (gem_engine_can_block_copy(src_fb->fd, e))
> > > +				break;
> > 
> > Hmm, this means we need to be careful when using cmds_info. As
> > not all engines support block-copy simple information from the
> > library (blt_has_block_copy()) is not enough.
> 
> Thanks for the comments Zbigniew, I fell out from this work for a while with
> Covid and now finally reached to state with all other things I can continue
> with this.
> 
> I wasn't certain what you meant with above comment? There would be better
> way to find correct engine for doing block copy? As is I'm testing new
> version of this set where these parts are bit changed, I'll probably
> today/tomorrow send another version for ci to show what I still missed.

I'm sorry for the confusion, I was sure gem_engine_can_block_copy() calls
i915_blt function which doesn't check engine capability, just reports platform
supports block-copy or not. Function you're using just does what I mean
- checks engine block-copy capability.

--
Zbigniew

> 
> My final target with all this is blitter path would do rc ccs and I'd need
> Vebox only for compressing mc ccs.
> 
> /Juha-Pekka
>