[igt-dev] [PATCH i-g-t v2 0/3] Initial tests for the lima drm driver

Erico Nunes nunes.erico at gmail.com
Tue Jun 6 14:43:16 UTC 2023


Hi,

On Mon, Jun 5, 2023 at 11:22 AM Zbigniew Kempczyński
<zbigniew.kempczynski at intel.com> wrote:
> I'm not the maintainer but sometimes I put my fingers here and there
> so I got a question and a nit. Do you have people involved in the
> project who contains the hardware and may verify test is working fine?

I'm one of the project contributors in both mesa and kernel, I should
be able to test/review contributions on what is related to the
specific hardware. Other project contributors are in cc.
As a side note I also noticed that there is hardware enrolled in
kernel-ci which can run the tests. Currently they already run igt, but
run generic igt tests since there have been no hardware specific ones
until now, and we could change it with these new tests.

> And definitely they can better review internal aspects of the test.
> IGT imo is correct place to put your tests in, only what I would change
> is to create additional 'lima/' directory. We treat 'tests/' directory
> as common so your specific driver tests should land to separate dir.
> lib/igt_lima.* is fine, but lima_gem_new.c should land to 'lima/'.

I'm fine with that, I'll change it in the next revision.

Thanks

Erico


More information about the igt-dev mailing list