[igt-dev] [PATCH v2 1/1] test/gem_create: limit set_pat to GEN12+ platforms

[Kamil Konieczny]

Hi Andi,

On 2023-06-06 at 13:59:30 +0200, Andi Shyti wrote:
> Hi Kamil,
> 
> On Tue, Jun 06, 2023 at 11:51:23AM +0200, Andi Shyti wrote:
> > From: Fei Yang <fei.yang at intel.com>
> > 
> > For platforms prior to GEN12 the set_pat extension should
----------------- ^ ------ ^
imho this also should be:
s/prior to GEN12/other than MTL/

as you enabled test only for MTL now.

> > return -ENODEV.
> > 
> > Signed-off-by: Fei Yang <fei.yang at intel.com>
> 
> I forgot:
> 
> Signed-off-by: Andi Shyti <andi.shyti at linux.intel.com> 
> 
> and also the title is wrong. May I kindly ask you to update it
> to:
> 
>    "test/gem_create: limit set_pat to Meteor Lake platforms"
> 
> Otherwise, if you prefer, I can resend it.
> 
> Andi
> 
> > ---
> >  tests/i915/gem_create.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
> > index e9e8216d2b..a3428e5890 100644
> > --- a/tests/i915/gem_create.c
> > +++ b/tests/i915/gem_create.c
> > @@ -657,6 +657,7 @@ static void create_ext_set_pat(int fd)
> >  		.base = { .name = I915_GEM_CREATE_EXT_SET_PAT },
> >  		.pat_index = 65,
> >  	};
> > +	uint32_t devid = intel_get_drm_devid(fd);
> >  	struct drm_i915_gem_caching arg;
> >  	uint64_t size;
> >  	uint32_t handle;
> > @@ -670,8 +671,13 @@ static void create_ext_set_pat(int fd)
> >  	 * With a valid PAT index specified, returning -EINVAL here
> >  	 * indicates set_pat extension is not supported
> >  	 */
> > -	if (ret == -EINVAL)
> > +	if (!IS_METEORLAKE(devid)) {

Put here
		if (ret == -EINVAL)
			igt_skip("EXT_SET_PAT unsupported\n");

> > +		igt_assert(ret == -ENODEV);
-------------------------^ ------- ^
On unsupported or older driver this returns -22 (-EINVAL),
I tested on Skylake gen9 iGPU. Btw better use:

	igt_assert_eq(ret, EXPECTED_VALUE);

Regards,
Kamil

> > +		return;
> > +	} else if (ret == -EINVAL) {
> >  		igt_skip("I915_GEM_CREATE_EXT_SET_PAT is not supported\n");
> > +	}
> > +
> >  	igt_assert(ret == 0);
> >  
> >  	/*
> > -- 
> > 2.40.1