[igt-dev] [PATCH i-g-t 2/2] tests/xe_vm.c: Add Negative test to VM error capture

[Kamil Konieczny]

Hi,

On 2023-06-09 at 05:44:22 +0000, Dandamudi, Priyanka wrote:
> 
> 
> > From: Janga Rahul Kumar <janga.rahul.kumar at intel.com>
> > 
> > Add negative test to check invalid arguments.
> > 
> > Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar at intel.com>
> > ---
> >  tests/xe/xe_vm.c | 28 ++++++++++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> > 
> > diff --git a/tests/xe/xe_vm.c b/tests/xe/xe_vm.c index 0da6c847..7f369fc4
> > 100644
> > --- a/tests/xe/xe_vm.c
> > +++ b/tests/xe/xe_vm.c
> > @@ -1638,6 +1638,31 @@ vm_error_capture_address(int fd)
> >  	xe_vm_destroy(fd, vm);
> >  }
> > 
> > +/**
> > + * SUBTEST: vm-error-capture-address-invalid-val
> > + * Description: Negative test to check vm error capture
> > + * Functionality: error capture
> > + * Run type: FULL
> > + * TODO: change ``'Run type' == FULL`` to a better category

[...cut...]

> > 
> > +	igt_subtest("vm-error-capture-address-invalid-val")
> > +		vm_error_capture_address_invalid_val(fd);
> > +
> >  	igt_fixture {
> >  		xe_device_put(fd);
> >  		close(fd);
> LGTM,
> Reviewed-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>

We should drop/change this, see reply from Matthew about uAPI
changing.

Regards,
Kamil

> > --
> > 2.25.1
>