[igt-dev] [PATCH i-g-t 1/1] lib: Let gen7 inherit gen4_render.h

[Kamil Konieczny]

Hi Christoph,

please add gen8 in subject:

lib: Let gen7/gen8 inherit gen4_render.h

On 2023-06-09 at 11:36:41 +0200, Christoph Manszewski wrote:
> Instead of redefining pipe selects, use them from gen4_render.h

imho it would be helpfull to add some explanation here,
maybe copy a sentence from cover letter.

> 
> Signed-off-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> Signed-off-by: Christoph Manszewski <christoph.manszewski at intel.com>
> ---
>  lib/gen7_media.h | 2 +-
>  lib/gen8_media.h | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/gen7_media.h b/lib/gen7_media.h
> index b5e49cae..93dc7312 100644
> --- a/lib/gen7_media.h
> +++ b/lib/gen7_media.h
> @@ -3,6 +3,7 @@
>  
>  #include <stdint.h>
>  #include "surfaceformat.h"
> +#include "gen4_render.h"
>  
>  #define GEN7_FLOATING_POINT_IEEE_754		0
>  #define GEN7_FLOATING_POINT_NON_IEEE_754	1
> @@ -13,7 +14,6 @@
>  						((Subopcode) << 16))
>  
>  #define GEN7_PIPELINE_SELECT			GFXPIPE(1, 1, 4)
> -# define PIPELINE_SELECT_3D			(0 << 0)
>  # define PIPELINE_SELECT_GPGPU			(2 << 0)
>  
>  #define GEN7_STATE_BASE_ADDRESS			GFXPIPE(0, 1, 1)
> diff --git a/lib/gen8_media.h b/lib/gen8_media.h
> index b5c19e50..01aaa9be 100644
> --- a/lib/gen8_media.h
> +++ b/lib/gen8_media.h
> @@ -13,7 +13,6 @@

imho you should also add:

#include "gen4_render.h"

into this header.

Regards,
Kamil

>  						((Subopcode) << 16))
>  
>  #define GEN8_PIPELINE_SELECT			GFXPIPE(1, 1, 4)
> -# define PIPELINE_SELECT_3D			(0 << 0)
>  
>  #define GEN8_STATE_BASE_ADDRESS			GFXPIPE(0, 1, 1)
>  
> -- 
> 2.40.1
>