[igt-dev] [PATCH i-g-t v2 3/4] tests/xe_waitfence: Rename vague subtest name "test" to reltime

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed Jun 14 10:35:41 UTC 2023


Hi Zbigniew,

On 2023-06-02 at 18:20:10 +0200, Zbigniew Kempczyński wrote:
> Wait user fence supports two techniques of passing timeout - relative
> and absolute. Rename current subtest name "test" to reltime to prepare
> the ground for adding new abstime subtest.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  tests/intel-ci/xe-fast-feedback.testlist | 2 +-
>  tests/xe/xe_waitfence.c                  | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index 69e70118ed..1552b6ea19 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -214,7 +214,7 @@ igt at xe_vm@munmap-style-unbind-userptr-end
>  igt at xe_vm@munmap-style-unbind-userptr-front
>  igt at xe_vm@munmap-style-unbind-userptr-inval-end
>  igt at xe_vm@munmap-style-unbind-userptr-inval-front
> -igt at xe_waitfence@test
> +igt at xe_waitfence@reltime
>  igt at kms_addfb_basic@addfb25-bad-modifier
>  igt at kms_addfb_basic@addfb25-modifier-no-flag
>  igt at kms_addfb_basic@bad-pitch-0
> diff --git a/tests/xe/xe_waitfence.c b/tests/xe/xe_waitfence.c
> index cdfcacdb47..390d9b3221 100644
> --- a/tests/xe/xe_waitfence.c
> +++ b/tests/xe/xe_waitfence.c
> @@ -38,11 +38,11 @@ static void do_bind(int fd, uint32_t vm, uint32_t bo, uint64_t offset,
>  }
>  
>  /**
> - * SUBTEST: test
> + * SUBTEST: reltime
>   * Description: Check basic waitfences functionality
>   */
>  static void
> -test(int fd)
> +waitfence(int fd)
>  {
>  	uint32_t bo_1;
>  	uint32_t bo_2;
> @@ -93,8 +93,8 @@ igt_main
>  		xe_device_get(fd);
>  	}
>  
> -	igt_subtest("test")
> -		test(fd);
> +	igt_subtest("reltime")
> +		waitfence(fd);
>  
>  	igt_fixture {
>  		xe_device_put(fd);
> -- 
> 2.34.1
> 


More information about the igt-dev mailing list