[igt-dev] [PATCH i-g-t] igt_core: Show the end of each subtest in dmesg

[Zbigniew Kempczyński]

On Mon, Jun 12, 2023 at 06:48:35PM +0200, Kamil Konieczny wrote:
> From: Chris Wilson <chris.p.wilson at linux.intel.com>
> 
> We have an igt_kmsg for the start of each test, and so we know
> the end by looking for the next start message or the end of the
> whole test. However, logs are split into each subtest and it is
> not clear in the kernel message where or even _if_ the test
> finished executing.
> 
> Signed-off-by: Chris Wilson <chris.p.wilson at linux.intel.com>
> Signed-off-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

LGTM:

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew

> ---
>  lib/igt_core.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index cd9c2002d..03a0ad693 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -1594,6 +1594,9 @@ __noreturn static void exit_subtest(const char *result)
>  				*subtest_name,
>  				result,
>  				igt_time_elapsed(thentime, &now));
> +	igt_kmsg(KMSG_INFO "%s: finished subtest %s, %s\n",
> +		 command_str, *subtest_name, result);
> +
>  	igt_terminate_spins();
>  
>  	/* If the subtest aborted, it may have left children behind */
> -- 
> 2.39.2
>