[igt-dev] [PATCH i-g-t v3 2/2] lib/igt_aux: Enable PM Suspend dbg messages

[Gupta, Anshuman]

> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit at intel.com>
> Sent: Thursday, June 22, 2023 11:22 PM
> To: Gupta, Anshuman <anshuman.gupta at intel.com>
> Cc: igt-dev at lists.freedesktop.org; kamil.konieczny at linux.intel.com; Nilawar,
> Badal <badal.nilawar at intel.com>; Tauro, Riana <riana.tauro at intel.com>
> Subject: Re: [PATCH i-g-t v3 2/2] lib/igt_aux: Enable PM Suspend dbg
> messages
> 
> On Wed, 21 Jun 2023 23:02:28 -0700, Anshuman Gupta wrote:
> >
> 
> Hi Anshuman,
> 
> > @@ -940,6 +950,14 @@ static void
> igt_aux_enable_pm_suspend_dbg(void)
> >		igt_warn("Unable to open printk parameters Err:%d\n",
> errno);
> >	}
> >
> > +	/* pm_debug_messages depends on  CONFIG_PM_SLEEP_DEBUG
> */
> > +	if (!faccessat(power_dir, "pm_debug_messages", R_OK |  W_OK, 0))
> {
> > +		__pm_debug_messages_state =
> igt_sysfs_get_boolean(sysfs_fd, "pm_debug_messages");
> > +		igt_sysfs_set_boolean(power_dir, "pm_debug_messages",
> true);
> > +	}
> > +
> > +
> 	igt_install_exit_handler(igt_aux_pm_suspend_dbg_restore_exit_ha
> ndler);
> 
> We already installed this exit handler in Patch 1 (under 'if (sysfs_fd >
> 0)') so we shouldn't install it twice, correct?
Thanks for noticing it , I messed it while rebasing. Rev2 has added only once.
Thanks,
Anshuman.
> 
> Thanks.
> --
> Ashutosh