[igt-dev] [PATCH v3 2/4] lib/igt_sysfs: Handling gt related sysfs uapi changes

Himal Prasad Ghimiray himal.prasad.ghimiray at intel.com
Tue Jun 27 12:23:03 UTC 2023


Patch https://patchwork.freedesktop.org/series/118927/
is moving gt sysfs parent under tile folder.

With the above patch path for sysfs changes:
from: /sys/class/drm/cardX/device/gtN/
to : /sys/class/drm/cardX/device/tileN/gtN

Adding xe_for_each_gt_under_each_tile macro to
access new path.

v2:
- Calculate number of tiles once within iterator. (Rahul)

v3:
- Drop usage of local variable for tilecount.
- Change order of tile and gt. (Ashutosh)

Reviewed-by: Upadhyay <tejas.upadhyay at intel.com>
Cc: Aravind Iddamsetty <aravind.iddamsetty at intel.com>
Cc: Upadhyay <tejas.upadhyay at intel.com>
Cc: Janga Rahul Kumar <janga.rahul.kumar at intel.com>
Cc: Francois Dugast <francois.dugast at intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit at intel.com>
Cc: Matt Roper <matthew.d.roper at intel.com>
Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
---
 lib/igt_sysfs.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lib/igt_sysfs.h b/lib/igt_sysfs.h
index de2c9a86..e4a0451b 100644
--- a/lib/igt_sysfs.h
+++ b/lib/igt_sysfs.h
@@ -80,6 +80,12 @@
 
 #define xe_for_each_tile for_each_sysfs_tile_dirfd
 
+/* FIXME: Need to revisit if GT indexing under TILE changes from KMD */
+#define xe_for_each_gt_under_each_tile(xe__, tile__, gt__) \
+	for (gt__ = 0, tile__ = 0; \
+	     gt__ < xe_number_gt(xe__); \
+	     (xe_number_gt(xe__) == igt_sysfs_get_num_tiles(xe__)) ? ++gt__, ++tile__ : ++gt__)
+
 enum i915_attr_id {
 	RPS_ACT_FREQ_MHZ,
 	RPS_CUR_FREQ_MHZ,
-- 
2.25.1



More information about the igt-dev mailing list